Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hapi): fix instrumentation of ESM-imported hapi #2184

Merged
merged 3 commits into from May 16, 2024

Conversation

aptomaKetil
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

FYI: These tests broke completely when depending on the recently released @opentelemetry/instrumentation-http v0.51.1, for reasons I couldn't figure out.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (dfb2dff) to head (d859e92).
Report is 125 commits behind head on main.

❗ Current head d859e92 differs from pull request most recent head 928d44e. Consider uploading reports for the commit 928d44e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2184      +/-   ##
==========================================
- Coverage   90.97%   90.47%   -0.50%     
==========================================
  Files         146      149       +3     
  Lines        7492     7594     +102     
  Branches     1502     1593      +91     
==========================================
+ Hits         6816     6871      +55     
- Misses        676      723      +47     
Files Coverage Δ
...emetry-instrumentation-hapi/src/instrumentation.ts 99.31% <100.00%> (+<0.01%) ⬆️

... and 34 files with indirect coverage changes

@aptomaKetil
Copy link
Contributor Author

Issues fixed, I've rebased on latest main. Ready to review.

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot. LGTM.

@trentm trentm enabled auto-merge (squash) May 16, 2024 00:26
@trentm trentm merged commit 265000a into open-telemetry:main May 16, 2024
8 of 9 checks passed
@dyladan dyladan mentioned this pull request May 16, 2024
@aptomaKetil aptomaKetil deleted the fix/hapi-esm branch May 16, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants