-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(propagator-grpc-cencus-binary): archive package #2201
chore(propagator-grpc-cencus-binary): archive package #2201
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2201 +/- ##
==========================================
- Coverage 90.97% 90.37% -0.61%
==========================================
Files 146 147 +1
Lines 7492 7500 +8
Branches 1502 1569 +67
==========================================
- Hits 6816 6778 -38
- Misses 676 722 +46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support deprecating it.
Regarding moving the files to archieve
, the one and only project there states that:
This project has been archived by the maintainers on August 3 2022 because it was causing a failure in the CI and does not have any maintainer.
Anyone who would like to maintain this project should open a PR to move it back into the lerna project and add themselves to the component owners file.
So I wonder, since we never plan to rejuvenate this package in the future, should we just remove it from the codebase altogether? It can always be picked up from git history if needed, but any reason we should keep the code?
I was going to say that it would be nice to update the npmjs.com page for this package to clarify where the source went, then... but I can't find any published-to-npm versions for that package name:
Anyway, handling the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot. Thanks, Marc.
Can we also add a deprecation message to the package per https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions ?
Some background and motivation for this PR are here: #2169 (comment) |
I think removing it is also okay. I'd keep it around for a bit and then remove it when there's no activity for one month or so after we mark it as deprecated in npm, we can remove it. I'll open a follow-up issue to track it.
Yep, I'll do that. |
This is a big win. No need to add |
Which problem is this PR solving?
grpc
has been deprecated since 2021. I propose we deprecate/archive the propagator to enable feat: support node 20 #2169, where this package is causing a build failure. This will also help contributors on macOS (on ARM) where it seems like the package needs to build the native grpc library every time it is pulled as no pre-built version is included.