chore: update core and API

[dyladan]

No description provided.

[Flarna]

a bot would be useful for such updates

[codecov]

Codecov Report

Merging #556 (52d55ab) into main (b9e00e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         169      169           
  Lines       10699    10699           
  Branches     1066     1066           
=======================================
  Hits        10138    10138           
  Misses        561      561           

[dyladan]

a bot would be useful for such updates

I was thinking the same thing. These PRs are quite a lot of work now that the version numbers between core and contrib match. Simple find and replace schemes are very difficult now.

[vmarchaud]

I opened an issue at the time to try to automate this #457

[obecny]

@dyladan Please don't merge such PR in future until the version from core 0.23 is released. I wanted to release patch for version 0.22 with fixed esm build and it is not possible now as the main branch already points to unreleased version of core 0.23.

[dyladan]

0.23 is released it is just under the @next tag until the 0.23.0 contrib release

[obecny]

0.23 is released

https://github.com/open-telemetry/opentelemetry-js it is still showing the latest to be 0.22, on screenshot you posted 0.22 is also marked as latest, shouldn't the 0.23 be latest ?

[obecny]

npm install @opentelemetry/core --save-dev and it will install 0.22

[dyladan]

If we make 0.23.0 latest then if a user does npm i @opentelemetry/node they will get 0.23.0 which is incompatible with the latest contrib. The last few releases were done this way. You can get 0.23 if you specifically ask for it like npm i @opentelemetry/node@0.23.0 or npm i @opentelemetry/node@next. The core release latest tag is always compatible with the contrib release latest tag. When contrib is released, the next tag is changed to latest.

npm install @opentelemetry/core --save-dev and it will install 0.22

Yes, that's on purpose

[dyladan]

If we apply the latest tag to core 0.23 and user does npm install @opentelemetry/node @opentelemetry/instrumenation-mysql they will get incompatible versions. With the current scheme it still works.

[obecny]

ok got it, thx

[dyladan]

We've done this for the last few releases. Users get confused if they install latest everything then get errors that versions aren't compatible.

[obecny]

any reason of not releasing the version contrib 0.23 yet ?

[obecny]

If we make 0.23.0 latest then if a user does npm i @opentelemetry/node they will get 0.23.0 which is incompatible with the latest contrib. The last few releases were done this way. You can get 0.23 if you specifically ask for it like npm i @opentelemetry/node@0.23.0 or npm i @opentelemetry/node@next. The core release latest tag is always compatible with the contrib release latest tag. When contrib is released, the next tag is changed to latest.

npm install @opentelemetry/core --save-dev and it will install 0.22

Yes, that's on purpose

what about https://github.com/open-telemetry/opentelemetry-js/releases, shouldn't the release 0.23 be visible here too ?

[dyladan]

oops yes i'll fix it

[dyladan]

https://github.com/open-telemetry/opentelemetry-js/releases/tag/v0.23.0