Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mongo): added missing exported types #564

Merged

Conversation

prsnca
Copy link
Contributor

@prsnca prsnca commented Jul 8, 2021

Which problem is this PR solving?

Short description of the changes

  • Added the new types MongoDBInstrumentationExecutionResponseHook and MongoResponseHookInformation to the export clause on index.ts

@prsnca prsnca requested a review from a team as a code owner July 8, 2021 07:10
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #564 (802690b) into main (83c7fa3) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   94.77%   94.72%   -0.06%     
==========================================
  Files         179      174       -5     
  Lines       10921    10797     -124     
  Branches     1086     1057      -29     
==========================================
- Hits        10350    10227     -123     
+ Misses        571      570       -1     
Impacted Files Coverage Δ
...strumentation-document-load/src/instrumentation.ts
...lemetry-instrumentation-document-load/src/utils.ts
...metry-instrumentation-document-load/src/version.ts
...entation-document-load/src/enums/AttributeNames.ts
...trumentation-document-load/src/enums/EventNames.ts

@vmarchaud
Copy link
Member

vmarchaud commented Jul 11, 2021

@prsnca You'll need to rebase the PR or allow us write access on your fork so we can rebase it for you

@prsnca prsnca force-pushed the add-missing-exported-mongo-types branch from 41ceff8 to 802690b Compare July 11, 2021 08:18
@nozik
Copy link
Contributor

nozik commented Jul 11, 2021

@vmarchaud I've granted you access, is there a group that I should also grant permissions to?

@vmarchaud
Copy link
Member

vmarchaud commented Jul 11, 2021

is there a group that I should also grant permissions to?

Yes actually if you could maintainers access, the group is open-telemetry/javascript-maintainers

@vmarchaud vmarchaud merged commit c0ad001 into open-telemetry:main Jul 11, 2021
@nozik nozik deleted the add-missing-exported-mongo-types branch September 23, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants