Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 55681 endpoint with 4318 endpoint for HTTP collector #603

Merged
merged 3 commits into from
Jan 24, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/connect/docker/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ version: "3"
services:
# Collector
collector:
image: otel/opentelemetry-collector:0.30.0
image: otel/opentelemetry-collector:0.38.0
# image: otel/opentelemetry-collector:latest
command: ["--config=/conf/collector-config.yaml", "--log-level=DEBUG"]
volumes:
- ./collector-config.yaml:/conf/collector-config.yaml
ports:
- "9464:9464"
- "4317:4317"
- "55681:55681"
- "4318:4318"
NathanielRN marked this conversation as resolved.
Show resolved Hide resolved
depends_on:
- zipkin-all-in-one

Expand Down
4 changes: 2 additions & 2 deletions examples/fastify/docker/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ version: "3"
services:
# Collector
collector:
image: otel/opentelemetry-collector:0.30.0
image: otel/opentelemetry-collector:0.38.0
# image: otel/opentelemetry-collector:latest
command: ["--config=/conf/collector-config.yaml", "--log-level=DEBUG"]
volumes:
- ./collector-config.yaml:/conf/collector-config.yaml
ports:
- "9464:9464"
- "4317:4317"
- "55681:55681"
- "4318:4318"
depends_on:
- zipkin-all-in-one

Expand Down
1 change: 0 additions & 1 deletion examples/graphql/docker/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ services:
- "9464:9464"
- "4317:4317"
- "4318:4318"
blumamir marked this conversation as resolved.
Show resolved Hide resolved
- "55681:55681"
depends_on:
- zipkin-all-in-one

Expand Down
1 change: 0 additions & 1 deletion examples/web/docker/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ services:
- "9464:9464"
- "4317:4317"
- "4318:4318"
- "55681:55681"
depends_on:
- zipkin-all-in-one

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export enum DomAttributes {

export enum PlaceholderValues {
ZIPKIN_URL = 'http://localhost:9411/api/v2/spans',
COLLECTOR_TRACE_URL = 'http://localhost:55681/v1/trace',
COLLECTOR_TRACE_URL = 'http://localhost:4318/v1/trace',
}

export enum Labels {
Expand Down