Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add AWS resource detector ownership #608

Merged
merged 3 commits into from Aug 7, 2021

Conversation

willarmiros
Copy link
Contributor

Extending #606

@willarmiros willarmiros requested a review from a team as a code owner August 6, 2021 17:39
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #608 (15a43ec) into main (66295ea) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 15a43ec differs from pull request most recent head e8bea1a. Consider uploading reports for the commit e8bea1a to get more accurate results

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
+ Coverage   94.88%   94.92%   +0.03%     
==========================================
  Files         155      191      +36     
  Lines        9577    11519    +1942     
  Branches      862     1109     +247     
==========================================
+ Hits         9087    10934    +1847     
- Misses        490      585      +95     
Impacted Files Coverage Δ
...opentelemetry-resource-detector-gcp/src/version.ts
...resource-detector-gcp/src/detectors/GcpDetector.ts
...ce-detector-gcp/test/detectors/GcpDetector.test.ts
...metry-resource-detector-gcp/src/detectors/index.ts
...entelemetry-instrumentation-restify/src/version.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-winston/src/version.ts 100.00% <0.00%> (ø)
...ntelemetry-instrumentation-router/src/constants.ts 100.00% <0.00%> (ø)
...strumentation-document-load/src/instrumentation.ts 98.79% <0.00%> (ø)
...metry-instrumentation-document-load/src/version.ts 100.00% <0.00%> (ø)
...metry-instrumentation-winston/test/winston.test.ts 97.87% <0.00%> (ø)
... and 34 more

@dyladan
Copy link
Member

dyladan commented Aug 6, 2021

@legendecas looks like you originally authored this package are you ok with ceding ownership to the AWS team?

@willarmiros
Copy link
Contributor Author

I mistakenly thought one of our engineers had contributed this package! Happy to share ownership with @legendecas or figure out something else

@willarmiros
Copy link
Contributor Author

Done

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyladan @willarmiros LGTM with ownership changes!

Actually, I was just moving the packages from opentelemtry-js repo in a very recent PR.

@vmarchaud vmarchaud merged commit 2d41152 into open-telemetry:main Aug 7, 2021
@willarmiros willarmiros deleted the patch-2 branch August 9, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants