Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GraphQL throws TypeError: Cannot read property 'startToken' of undefined #619

Merged
merged 4 commits into from Aug 31, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Aug 13, 2021

Which problem is this PR solving?

Short description of the changes

  • the graphqlTypes.Location is now always available so the param should be optional, previously it was required and it was causing the error then location was missing

@obecny obecny added the bug Something isn't working label Aug 13, 2021
@obecny obecny requested a review from a team as a code owner August 13, 2021 19:22
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #619 (980c0b9) into main (8584432) will decrease coverage by 1.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   96.68%   95.17%   -1.52%     
==========================================
  Files          13       25      +12     
  Lines         634     1596     +962     
  Branches      124      217      +93     
==========================================
+ Hits          613     1519     +906     
- Misses         21       77      +56     
Impacted Files Coverage Δ
...opentelemetry-instrumentation-graphql/src/utils.ts 95.29% <100.00%> (ø)
...ages/auto-instrumentations-node/test/utils.test.ts 96.87% <0.00%> (ø)
.../opentelemetry-instrumentation-graphql/src/enum.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-graphql/src/types.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-graphql/src/version.ts 100.00% <0.00%> (ø)
...nstrumentation-graphql/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...try-instrumentation-graphql/src/instrumentation.ts 92.72% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 96.77% <0.00%> (ø)
...entelemetry-instrumentation-graphql/test/helper.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-graphql/src/symbols.ts 100.00% <0.00%> (ø)
... and 3 more

@dyladan dyladan merged commit 5fb3313 into open-telemetry:main Aug 31, 2021
@obecny obecny deleted the graphql-fix branch August 31, 2021 17:37
@dyladan dyladan mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL throws TypeError: Cannot read property 'startToken' of undefined
4 participants