Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(test-utils): marking test-utils as non private so it can be published #639

Merged
merged 11 commits into from Aug 30, 2021

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Aug 25, 2021

Follows #596

Which problem is this PR solving?

Short description of the changes

  • mark test-utils as non private (so it can be published to npm)
  • add missing LICENCE file
  • add "files" section to package.json to state which files should be included in a release
  • rename test-utils to contrib-test-utils

@blumamir blumamir requested a review from a team as a code owner August 25, 2021 10:23
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #639 (97a1efc) into main (d711127) will decrease coverage by 1.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   96.68%   95.22%   -1.47%     
==========================================
  Files          13       67      +54     
  Lines         634     4582    +3948     
  Branches      124      426     +302     
==========================================
+ Hits          613     4363    +3750     
- Misses         21      219     +198     
Impacted Files Coverage Δ
...oud/test/detectors/AlibabaCloudEcsDetector.test.ts 94.44% <ø> (ø)
...or-aws/test/detectors/AwsBeanstalkDetector.test.ts 100.00% <ø> (ø)
...detector-aws/test/detectors/AwsEc2Detector.test.ts 95.16% <ø> (ø)
...detector-aws/test/detectors/AwsEcsDetector.test.ts 100.00% <ø> (ø)
...detector-aws/test/detectors/AwsEksDetector.test.ts 100.00% <ø> (ø)
...ector-aws/test/detectors/AwsLambdaDetector.test.ts 100.00% <ø> (ø)
...ce-detector-gcp/test/detectors/GcpDetector.test.ts 100.00% <ø> (ø)
...ntelemetry-instrumentation-pg/test/pg-pool.test.ts 91.42% <100.00%> (ø)
...e/opentelemetry-instrumentation-pg/test/pg.test.ts 95.01% <100.00%> (ø)
.../opentelemetry-instrumentation-mysql2/src/utils.ts 100.00% <0.00%> (ø)
... and 53 more

@blumamir blumamir changed the title build: marking test-utils as non private so it can be published build(test-utils): marking test-utils as non private so it can be published Aug 25, 2021
Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dyladan hopefully this can go out in contrib release 0.25.0 so we can unblock the ext-js migrations ASAP!

@dyladan dyladan linked an issue Aug 27, 2021 that may be closed by this pull request
@blumamir
Copy link
Member Author

LGTM. @dyladan hopefully this can go out in contrib release 0.25.0 so we can unblock the ext-js migrations ASAP!

@dyladan Fixed the conflicts and now tests are green

@dyladan dyladan merged commit 1771b60 into open-telemetry:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish test-utils as a package on NPM
8 participants