Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mysql2): adding TAV script #641

Merged
merged 8 commits into from Aug 30, 2021
Merged

Conversation

YanivD
Copy link
Member

@YanivD YanivD commented Aug 25, 2021

Which problem is this PR solving?

This will let us run test-all-versions scripts for mysql2 plugin, and make sure tests are green for all versions supported by the instrumentations.

Currently this is just a script in package.json which can be run manually on demand by user to verify compatibility. This is not integrated into CI or expected to impact project in any way.

@YanivD YanivD requested a review from a team as a code owner August 25, 2021 13:43
@YanivD YanivD marked this pull request as draft August 25, 2021 13:49
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #641 (8525c16) into main (1771b60) will decrease coverage by 1.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   96.68%   95.18%   -1.51%     
==========================================
  Files          13       67      +54     
  Lines         634     4588    +3954     
  Branches      124      427     +303     
==========================================
+ Hits          613     4367    +3754     
- Misses         21      221     +200     
Impacted Files Coverage Δ
...try-instrumentation-ioredis/src/instrumentation.ts 100.00% <0.00%> (ø)
...metry-instrumentation-mysql/src/instrumentation.ts 93.38% <0.00%> (ø)
...metry-resource-detector-gcp/src/detectors/index.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-ioredis/src/utils.ts 91.66% <0.00%> (ø)
...telemetry-instrumentation-cassandra/src/version.ts 100.00% <0.00%> (ø)
...metry-instrumentation-redis/src/instrumentation.ts 93.47% <0.00%> (ø)
...or-aws/test/detectors/AwsBeanstalkDetector.test.ts 100.00% <0.00%> (ø)
...ector-aws/test/detectors/AwsLambdaDetector.test.ts 100.00% <0.00%> (ø)
...ource-detector-aws/src/detectors/AwsEc2Detector.ts 97.91% <0.00%> (ø)
...node/opentelemetry-instrumentation-pg/src/utils.ts 97.61% <0.00%> (ø)
... and 44 more

@YanivD
Copy link
Member Author

YanivD commented Aug 25, 2021

I'm putting this PR in draft mode, I found some issues for <=2.1.0 versions.
I'm investigating the issue

@YanivD
Copy link
Member Author

YanivD commented Aug 30, 2021

After fixing broken tests for older versions (v2.0.0, v2.0.1, v2.0.2, v2.1.0)
PR is ready for review

@YanivD YanivD marked this pull request as ready for review August 30, 2021 09:11
@dyladan
Copy link
Member

dyladan commented Aug 30, 2021

Might be worth making the fixes in a separate fix: PR so it can be properly detected as a bug by tooling

@YanivD
Copy link
Member Author

YanivD commented Aug 30, 2021

Might be worth making the fixes in a separate fix: PR so it can be properly detected as a bug by tooling

The fix is relevant only for the tests, it doesn't change the instrumentation code.

@dyladan dyladan merged commit ee0debf into open-telemetry:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants