Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency eslint to v8 #699

Merged
merged 7 commits into from Jan 31, 2022
Merged

chore(deps): update dependency eslint to v8 #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1359c69
chore(deps): update dependency eslint to v8
renovate-bot Jan 16, 2022
995b62f
Merge branch 'main' into renovate/eslint-8.x
Jan 26, 2022
1ba53ef
Merge branch 'main' into renovate/eslint-8.x
Jan 27, 2022
ab174ca
Merge branch 'main' into renovate/eslint-8.x
vmarchaud Jan 29, 2022
c32d203
Merge branch 'main' into renovate/eslint-8.x
Jan 30, 2022
eee58a5
Merge branch 'main' into renovate/eslint-8.x
Jan 31, 2022
9220bc5
Merge branch 'main' into renovate/eslint-8.x
Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -51,7 +51,7 @@
"@typescript-eslint/eslint-plugin": "5.8.1",
"@typescript-eslint/parser": "5.8.1",
"colors": "1.4.0",
"eslint": "7.32.0",
"eslint": "8.7.0",
"eslint-config-airbnb-base": "14.2.1",
"eslint-plugin-header": "3.1.1",
"eslint-plugin-import": "2.23.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-browser-extension-autoinjection/package.json
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@
"@typescript-eslint/parser": "5.8.1",
"codecov": "3.8.3",
"colors": "1.4.0",
"eslint": "7.32.0",
"eslint": "8.7.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to the version bump, but should we remove eslint dependency and other eslint related packages from the subpackages, and keep it only in root?

    "@typescript-eslint/eslint-plugin": "5.8.1",
    "@typescript-eslint/parser": "5.8.1",
    "eslint": "7.32.0",
    "eslint-config-airbnb-base": "14.2.1",
    "eslint-plugin-header": "3.1.1",
    "eslint-plugin-import": "2.23.4",
    "eslint-plugin-json5": "0.1.3",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we can since the deps aren't hoisted, this would mean that you couldn't run eslint independently for a specific repo ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is only specified on browser-extension-autoinject and instrumentation-aws-sdk.
If it's needed per package then we should also add it to all other packages in the repo, but I think it's better to configure and run lint on the entire repo from the root, and not per package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browser-extension-autoinject use eslint-plugin-json5.
I believe it can be hoisted to the repo root.

"eslint-config-airbnb-base": "14.2.1",
"eslint-plugin-header": "3.1.1",
"eslint-plugin-import": "2.23.4",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-aws-sdk/package.json
View file
Open in desktop
Expand Up @@ -63,7 +63,7 @@
"@types/node": "16.11.21",
"@types/sinon": "10.0.6",
"aws-sdk": "2.1008.0",
"eslint": "7.32.0",
"eslint": "8.7.0",
"expect": "27.4.2",
"mocha": "7.2.0",
"nock": "13.2.1",
Expand Down