Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused ts-node dependencies #835

Merged
merged 3 commits into from Jan 14, 2022

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Jan 14, 2022

Which problem is this PR solving?

  • Following discussion here, with the great eye of @rauno56 , It was noticed that ts-node dependency is installed but not used in instrumentation-aws-sdk and browser-extension-autoinjection.

Short description of the changes

  • This PR removes these unused dependencies which can also slightly improve install and CI times.

When this PR merges, there will be no dependencies on ts-node in the repo

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #835 (feaa83c) into main (9326c99) will increase coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   94.90%   95.72%   +0.81%     
==========================================
  Files          13       39      +26     
  Lines         707     2081    +1374     
  Branches      142      267     +125     
==========================================
+ Hits          671     1992    +1321     
- Misses         36       89      +53     
Impacted Files Coverage Δ
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 96.91% <0.00%> (ø)
...extension-autoinjection/test/contentScript.test.ts 100.00% <0.00%> (ø)
...er-extension-autoinjection/test/background.test.ts 100.00% <0.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <0.00%> (ø)
...er-extension-autoinjection/src/background/index.ts 0.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
...etry-browser-extension-autoinjection/test/utils.ts 100.00% <0.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.29% <0.00%> (ø)
...ction/src/contentScript/InstrumentationInjector.ts 100.00% <0.00%> (ø)
... and 16 more

@dyladan dyladan merged commit fb68182 into open-telemetry:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants