Skip to content

Commit

Permalink
test: startActiveSpan ensure that ctx sent is used
Browse files Browse the repository at this point in the history
also add commented out span equality assertions to be uncommented before
merging

Signed-off-by: naseemkullah <naseem@transit.app>
  • Loading branch information
naseemkullah committed May 24, 2021
1 parent d5c8131 commit 2581011
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions packages/opentelemetry-tracing/test/Tracer.test.ts
Expand Up @@ -16,6 +16,8 @@

import {
context,
createContextKey,
getSpan,
INVALID_TRACEID,
ROOT_CONTEXT,
Sampler,
Expand Down Expand Up @@ -222,7 +224,7 @@ describe('Tracer', () => {
span.end();
});

it('should start an active span with name and function as args', () => {
it('should start an active span with name and function args', () => {
const tracer = new Tracer(
{ name: 'default', version: '0.0.1' },
{ sampler: new TestSampler() },
Expand All @@ -231,14 +233,15 @@ describe('Tracer', () => {

assert.strictEqual(tracer.startActiveSpan('my-span', span => {
try {
// assert.strictEqual(getSpan(context.active()), span)
return 1
} finally {
span.end();
}
}), 1);
});

it('should start an active span with name, options and functin as args', () => {
it('should start an active span with name, options and function args', () => {
const tracer = new Tracer(
{ name: 'default', version: '0.0.1' },
{ sampler: new TestSampler() },
Expand All @@ -247,22 +250,29 @@ describe('Tracer', () => {

assert.strictEqual(tracer.startActiveSpan('my-span', {}, span => {
try {
// assert.strictEqual(getSpan(context.active()), span)
return 1
} finally {
span.end();
}
}), 1);
});

it('should start an active span with name, options, context and function as args', () => {
it('should start an active span with name, options, context and function args', () => {
const tracer = new Tracer(
{ name: 'default', version: '0.0.1' },
{ sampler: new TestSampler() },
tracerProvider
);

assert.strictEqual(tracer.startActiveSpan('my-span', {}, context.active(), span => {
const ctxKey = createContextKey('foo');

const ctx = context.active().setValue(ctxKey, 'bar')

assert.strictEqual(tracer.startActiveSpan('my-span', {}, ctx, span => {
try {
// assert.strictEqual(getSpan(context.active()), span)
assert.strictEqual(ctx.getValue(ctxKey), 'bar')
return 1
} finally {
span.end();
Expand Down

0 comments on commit 2581011

Please sign in to comment.