chore(api-metrics): fix lint warnings

open-telemetry · Aug 3, 2021 · 7e00ab7 · 7e00ab7
1 parent 3b9cd16
commit 7e00ab7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/opentelemetry-api-metrics/src/NoopMeter.ts b/packages/opentelemetry-api-metrics/src/NoopMeter.ts
@@ -159,23 +159,23 @@ export class NoopMetric<T> implements UnboundMetric<T> {
 export class NoopCounterMetric
   extends NoopMetric<BoundCounter>
   implements Counter {
-  add(value: number, labels: Labels) {
+  add(value: number, labels: Labels): void {
     this.bind(labels).add(value);
   }
 }
 
 export class NoopValueRecorderMetric
   extends NoopMetric<BoundValueRecorder>
   implements ValueRecorder {
-  record(value: number, labels: Labels) {
+  record(value: number, labels: Labels): void {
     this.bind(labels).record(value);
   }
 }
 
 export class NoopBaseObserverMetric
   extends NoopMetric<BoundBaseObserver>
   implements BaseObserver {
-  observation() {
+  observation(): { observer: BaseObserver; value: number; } {
     return {
       observer: this as BaseObserver,
       value: 0,
@@ -198,7 +198,7 @@ export class NoopBoundValueRecorder implements BoundValueRecorder {
 }
 
 export class NoopBoundBaseObserver implements BoundBaseObserver {
-  update(_value: number) {}
+  update(_value: number): void {}
 }
 
 export const NOOP_METER = new NoopMeter();

diff --git a/packages/opentelemetry-api-metrics/src/api/metrics.ts b/packages/opentelemetry-api-metrics/src/api/metrics.ts
@@ -78,7 +78,7 @@ export class MetricsAPI {
   }
 
   /** Remove the global meter provider */
-  public disable() {
+  public disable(): void {
     delete _global[GLOBAL_METRICS_API_KEY];
   }
 }