Skip to content

Commit

Permalink
docs: updated example in README to match updated start method (#3684)
Browse files Browse the repository at this point in the history
  • Loading branch information
martinkuba committed Mar 17, 2023
1 parent a96e429 commit 7e9ff24
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/

### :books: (Refine Doc)

* doc(sdk): update NodeSDK example [#3684](https://github.com/open-telemetry/opentelemetry-js/pull/3684) @martinkuba

### :house: (Internal)

## 1.10.0
Expand Down
6 changes: 1 addition & 5 deletions experimental/packages/opentelemetry-sdk-node/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,7 @@ const sdk = new opentelemetry.NodeSDK({
// See the Configuration section below for additional configuration options
});

// You can optionally detect resources asynchronously from the environment.
// Detected resources are merged with the resources provided in the SDK configuration.
sdk.start().then(() => {
// Resources have been detected and SDK is started
});
sdk.start();

// You can also use the shutdown method to gracefully shut down the SDK before process shutdown
// or on some operating system signal.
Expand Down

0 comments on commit 7e9ff24

Please sign in to comment.