Skip to content

Commit

Permalink
Find a replace all 55681 endpoints with 4318 for HTTP
Browse files Browse the repository at this point in the history
  • Loading branch information
NathanielRN committed Aug 4, 2021
1 parent c33463a commit 97407c5
Show file tree
Hide file tree
Showing 12 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion examples/basic-tracer-node/docker/ot/docker-compose.yaml
Expand Up @@ -10,7 +10,7 @@ services:
ports:
- "9464:9464"
- "4317:4317"
- "55681:55681"
- "4318:4318"
depends_on:
- jaeger-all-in-one

Expand Down
Expand Up @@ -10,7 +10,7 @@ services:
ports:
- "9464:9464"
- "4317:4317"
- "55681:55681"
- "4318:4318"
depends_on:
- zipkin-all-in-one

Expand Down
2 changes: 1 addition & 1 deletion examples/collector-exporter-node/metrics.js
Expand Up @@ -12,7 +12,7 @@ const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventi
diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG);

const metricExporter = new CollectorMetricExporter({
// url: 'http://localhost:55681/v1/metrics',
// url: 'http://localhost:4318/v1/metrics',
});

const meter = new MeterProvider({
Expand Down
4 changes: 2 additions & 2 deletions packages/opentelemetry-exporter-collector-proto/README.md
Expand Up @@ -25,7 +25,7 @@ const { BasicTracerProvider, SimpleSpanProcessor } = require('@opentelemetry/tra
const { CollectorTraceExporter } = require('@opentelemetry/exporter-collector-proto');

const collectorOptions = {
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:55681/v1/traces
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:4318/v1/traces
headers: {
foo: 'bar'
}, //an optional object containing custom headers to be sent with each request will only work with http
Expand All @@ -45,7 +45,7 @@ provider.register();
const { MeterProvider } = require('@opentelemetry/metrics');
const { CollectorMetricExporter } = require('@opentelemetry/exporter-collector-proto');
const collectorOptions = {
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:55681/v1/metrics
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:4318/v1/metrics
};
const exporter = new CollectorMetricExporter(collectorOptions);

Expand Down
8 changes: 4 additions & 4 deletions packages/opentelemetry-exporter-collector/README.md
Expand Up @@ -28,7 +28,7 @@ import { WebTracerProvider } from '@opentelemetry/web';
import { CollectorTraceExporter } from '@opentelemetry/exporter-collector';

const collectorOptions = {
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:55681/v1/trace
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:4318/v1/trace
headers: {}, // an optional object containing custom headers to be sent with each request
concurrencyLimit: 10, // an optional limit on pending requests
};
Expand Down Expand Up @@ -58,7 +58,7 @@ The CollectorMetricExporter in Web expects the endpoint to end in `/v1/metrics`.
import { MeterProvider } from '@opentelemetry/metrics';
import { CollectorMetricExporter } from '@opentelemetry/exporter-collector';
const collectorOptions = {
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:55681/v1/metrics
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:4318/v1/metrics
headers: {}, // an optional object containing custom headers to be sent with each request
concurrencyLimit: 1, // an optional limit on pending requests
};
Expand All @@ -83,7 +83,7 @@ const { BasicTracerProvider, BatchSpanProcessor } = require('@opentelemetry/trac
const { CollectorTraceExporter } = require('@opentelemetry/exporter-collector');

const collectorOptions = {
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:55681/v1/trace
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:4318/v1/trace
headers: {
foo: 'bar'
}, // an optional object containing custom headers to be sent with each request will only work with http
Expand All @@ -109,7 +109,7 @@ provider.register();
const { MeterProvider } = require('@opentelemetry/metrics');
const { CollectorMetricExporter } = require('@opentelemetry/exporter-collector');
const collectorOptions = {
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:55681/v1/metrics
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:4318/v1/metrics
concurrencyLimit: 1, // an optional limit on pending requests
};
const exporter = new CollectorMetricExporter(collectorOptions);
Expand Down
Expand Up @@ -21,7 +21,7 @@ import { CollectorExporterBrowserBase } from './CollectorExporterBrowserBase';
import { toCollectorExportMetricServiceRequest } from '../../transformMetrics';
import { getEnv, baggageUtils } from '@opentelemetry/core';

const DEFAULT_COLLECTOR_URL = 'http://localhost:55681/v1/metrics';
const DEFAULT_COLLECTOR_URL = 'http://localhost:4318/v1/metrics';

/**
* Collector Metric Exporter for Web
Expand Down
Expand Up @@ -21,7 +21,7 @@ import { toCollectorExportTraceServiceRequest } from '../../transform';
import * as collectorTypes from '../../types';
import { getEnv, baggageUtils } from '@opentelemetry/core';

const DEFAULT_COLLECTOR_URL = 'http://localhost:55681/v1/traces';
const DEFAULT_COLLECTOR_URL = 'http://localhost:4318/v1/traces';

/**
* Collector Trace Exporter for Web
Expand Down
Expand Up @@ -21,7 +21,7 @@ import { CollectorExporterNodeBase } from './CollectorExporterNodeBase';
import { toCollectorExportMetricServiceRequest } from '../../transformMetrics';
import { getEnv, baggageUtils } from '@opentelemetry/core';

const DEFAULT_COLLECTOR_URL = 'http://localhost:55681/v1/metrics';
const DEFAULT_COLLECTOR_URL = 'http://localhost:4318/v1/metrics';

/**
* Collector Metric Exporter for Node
Expand Down
Expand Up @@ -21,7 +21,7 @@ import * as collectorTypes from '../../types';
import { toCollectorExportTraceServiceRequest } from '../../transform';
import { getEnv, baggageUtils } from '@opentelemetry/core';

const DEFAULT_COLLECTOR_URL = 'http://localhost:55681/v1/traces';
const DEFAULT_COLLECTOR_URL = 'http://localhost:4318/v1/traces';

/**
* Collector Trace Exporter for Node
Expand Down
Expand Up @@ -293,7 +293,7 @@ describe('CollectorTraceExporter - browser (getDefaultUrl)', () => {
setTimeout(() => {
assert.strictEqual(
collectorExporter['url'],
'http://localhost:55681/v1/traces'
'http://localhost:4318/v1/traces'
);
done();
});
Expand Down
Expand Up @@ -292,7 +292,7 @@ describe('CollectorMetricExporter - node with json over http', () => {
setTimeout(() => {
assert.strictEqual(
collectorExporter['url'],
'http://localhost:55681/v1/metrics'
'http://localhost:4318/v1/metrics'
);
done();
});
Expand Down
Expand Up @@ -317,7 +317,7 @@ describe('CollectorTraceExporter - node with json over http', () => {
setTimeout(() => {
assert.strictEqual(
collectorExporter['url'],
'http://localhost:55681/v1/traces'
'http://localhost:4318/v1/traces'
);
done();
});
Expand Down

0 comments on commit 97407c5

Please sign in to comment.