Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter-collector-http: log error when it fails to export #1459

Closed
vmarchaud opened this issue Aug 24, 2020 · 6 comments · Fixed by #1607
Closed

exporter-collector-http: log error when it fails to export #1459

vmarchaud opened this issue Aug 24, 2020 · 6 comments · Fixed by #1607
Assignees

Comments

@vmarchaud
Copy link
Member

Currently the collector-exporter in HTTP just log that the export failed with only the status code. We should get the error and log it in the console for end users to find what's wrong.
For example i was debugging an 400 and to debug i had to publish another package with more logs to see that the error was:

{"error":"Request was missing field timeSeries[0].points[0].interval.endTime: The end time of the interval is required.","code":3,"message":"Request was missing field timeSeries[0].points[0].interval.endTime: The end time of the interval is required."}

cc @obecny do you want to tackle it ?

@obecny
Copy link
Member

obecny commented Aug 24, 2020

@vmarchaud sure

@obecny obecny self-assigned this Aug 24, 2020
@obecny
Copy link
Member

obecny commented Sep 9, 2020

@vmarchaud I think this will be irrelevant once the global error handler is implemented -> #1415

@vmarchaud
Copy link
Member Author

Well on the error handling side yes, one thing we could add on the error still is the response body.

@vmarchaud vmarchaud assigned vmarchaud and unassigned obecny Oct 20, 2020
@vmarchaud
Copy link
Member Author

I needed that for my deployment so i've developped it, hope you didn't started that in the mean time

vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Oct 20, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Oct 20, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Oct 24, 2020
@dyladan
Copy link
Member

dyladan commented Oct 26, 2020

@vmarchaud does #1607 fix this issue? If so, please link the PR.

@vmarchaud vmarchaud linked a pull request Oct 26, 2020 that will close this issue
@vmarchaud
Copy link
Member Author

@dyladan Done, i though it was autoamtic if i tagged the issue in the PR title :/

vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Nov 6, 2020
dyladan added a commit that referenced this issue Nov 11, 2020
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants