Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter-collector): log upstream error #1459 #1607

Merged
merged 6 commits into from
Nov 11, 2020

Conversation

vmarchaud
Copy link
Member

As stated in the issue, before it was impossible to know why we couldnt push to the collector.

@vmarchaud vmarchaud self-assigned this Oct 20, 2020
@vmarchaud vmarchaud added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2020
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise it looks finne, can you fix build as it is failing everywhere ?

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #1607 (2a6cdb5) into master (e78f65e) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1607      +/-   ##
==========================================
- Coverage   91.35%   91.32%   -0.04%     
==========================================
  Files         165      160       -5     
  Lines        5042     4771     -271     
  Branches     1040      978      -62     
==========================================
- Hits         4606     4357     -249     
+ Misses        436      414      -22     
Impacted Files Coverage Δ
...kages/opentelemetry-exporter-collector/src/util.ts
.../opentelemetry-exporter-collector/src/transform.ts
...lemetry-exporter-collector/src/transformMetrics.ts
...ry-exporter-collector/src/CollectorExporterBase.ts

@vmarchaud
Copy link
Member Author

@obecny I've rebased and fixed the build ! PTAL

@vmarchaud
Copy link
Member Author

cc @open-telemetry/javascript-approvers this one only need one more review :)

@dyladan dyladan added the enhancement New feature or request label Nov 11, 2020
@dyladan dyladan merged commit deb0cc7 into open-telemetry:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exporter-collector-http: log error when it fails to export
5 participants