Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: implement an option to limit length of values of attributes and metric values #2403

Closed
rauno56 opened this issue Aug 6, 2021 · 7 comments · Fixed by #2418 or #2430
Closed

Spec: implement an option to limit length of values of attributes and metric values #2403

rauno56 opened this issue Aug 6, 2021 · 7 comments · Fixed by #2418 or #2430
Assignees

Comments

@rauno56
Copy link
Member

rauno56 commented Aug 6, 2021

Ref: open-telemetry/opentelemetry-specification#1130

@vmarchaud vmarchaud added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Aug 7, 2021
@CptSchnitz
Copy link
Contributor

CptSchnitz commented Aug 9, 2021

will the length limit will be configurable from the code, or only from env? (from looking at the java implementation it looked only from env, but I'm not that good with java)

@banothurameshnaik
Copy link
Contributor

Hey,

I would like to contribute to this feature if no other working on the same.

@rauno56 can you assign this to me.

@banothurameshnaik
Copy link
Contributor

Hey all,

I implemented the option to limit length of attribute values (not yet for metrics).

Please have a look into #2418

@rauno56
Copy link
Member Author

rauno56 commented Aug 24, 2021

OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT is now covered! Thanks, @banothurameshnaik!
Reopening it because the spec has two other attributes:

  • OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT and
  • OTEL_ATTRIBUTE_COUNT_LIMIT.

@rauno56 rauno56 reopened this Aug 24, 2021
@banothurameshnaik
Copy link
Contributor

@rauno56
I will continue working on implementing these two attributes also.
Will raise another PR.

@banothurameshnaik
Copy link
Contributor

Hi,
I made an PR with OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT and OTEL_ATTRIBUTE_COUNT_LIMIT limits.
Please have a look.

#2430

@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Aug 29, 2021
@rauno56
Copy link
Member Author

rauno56 commented Sep 10, 2021

Awesome work independently taking this from start to finish, @banothurameshnaik! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment