New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Convention Update: Tracking Issue #4572
Comments
@MSNev @pichlermarc I created this issue based on our conversation in the SIG meeting to help track the work required to update semantic conventions in otel-js. I believe the first and last few items here are generally uncontroversial, but I wanted to confirm the appropriate step is listed for keeping old semantic convention version intact. Some languages have a subdirectory of every semconv version as mentioned here. At some point we've also talked about rolling our own that essentially just adds the new attributes into new files to be additive to the existing package, instead of keeping whole packages for each version. Curious for feedback on the approach we want to take. |
I think a couple things could be improved in
|
Fixes #11755 OpenTelemetry restructured their http semantic conventions and declared them stable: https://opentelemetry.io/blog/2023/http-conventions-declared-stable/ This has unfortunately not been reflected in OpenTelemetry JS yet, blocked on them making everything backwards compat: open-telemetry/opentelemetry-js#4572 For now we can directly reference `http.request.method`, the replacement to `http.method`. When the OTEL SDK is finally updated to use proper conventions, we can avoid hard coding the string.
Current Status
Current (latest) package of
@opentelemetry/semantic-conventions
uses semconv version v1.7.0, as seen inscripts/semconv/generate.sh
.There are breaking changes in semantic conventions over time, especially prominent in v1.21 with stabilized http attributes, so we want to update in a way that minimizes impact on end users and offers the environment variable option
OTEL_SEMCONV_STABILITY_OPT_IN
to allow specifying which attributes to use. See schema for 1.23.1 here that shows changes over time.Steps required for semantic convention update
@opentelemetry/semantic-conventions-1_7
), and update imports everywhere, as suggested on #4235scripts/semconv
. In addition to the change inSPEC_VERSION
, this will require further changes to repos and directories as the source files for semantic conventions migrated fromopen-telemetry/opentelemetry-specification
toopen-telemetry/semantic-conventions
, and directories updated as well. For example,trace/http.yaml
is nowmodel/trace/http.yaml
.OTEL_SEMCONV_STABILITY_OPT_IN
that includeshttp
andhttp/dup
options as suggested in the Migration Plan.The text was updated successfully, but these errors were encountered: