fix(host-metrics): semcov alignment & macOS fix #2071

Netail · 2024-03-30T00:00:24Z

Which problem is this PR solving?

Reduce bundle size by only import the correct function (And so that osx-temp on macOS is not required, as cpu.js of the 'systeminformation' dep isn't even used)
Alignment of semconv

Short description of the changes

Renamed enum value
Use specific file, instead of bundling all file of package

linux-foundation-easycla · 2024-03-30T00:00:29Z

The committers listed above are authorized under a signed CLA.

✅ login: Netail / name: Maikel (ce92ffe, a2aaa4b, a8196e4, 65aabe7, 8f65520, d1c1fca, e818ba5, 2484ef6, 63cc39d, 08506a4, 2c6d8cf, ae578fc, 1106e97, a3b898f, 744ea1d, 03e2237, 304dc98, 9f81a2d, 60e0933, 83c58a3, 769de9e, cc8aafe, 343733e, 4fd1f8f, 2ac772e, 9c30315, 9cbe462, b642766, 38b80b1, fd50fe5)

pichlermarc · 2024-04-02T12:29:38Z

packages/opentelemetry-host-metrics/src/stats/si.ts

@@ -14,12 +14,12 @@
 * limitations under the License.
 */

-import * as SI from 'systeminformation';
+import { networkStats } from 'systeminformation/lib/network';


I'm not sure about systeminformation but deep-imports like this are usually not covered by stability guarantees. would this work for you?

Suggested change

import { networkStats } from 'systeminformation/lib/network';

import { networkStats } from 'systeminformation';

@pichlermarc Sadly not, it still imports the /lib/cpu file for some reason. Resulting in having to add the unnecessary dependency osx-temperature-sensor, which is not even used by networkStats()

Resulting in having to add the unnecessary dependency osx-temperature-sensor,

Why "having to add"? It looks like lib/cpu.js lazily does require('osx-temperature-sensor') only if cpuTemperature() is called.

Netail · 2024-04-02T14:41:14Z

CI/CD should be fixed now :) (btw; npm install fails with Node 20 due to grpc)

david-luna · 2024-04-04T11:45:07Z

Hi @Netail

Thank you for contributing to OTEL :)

We can leverage this PR to help effort the group is doing to update the semantic conventions. Currently we're in a step we need to use the exported strings as you did in this PR and also document which version of the semantic conventions is using.

Would you please add a section in the README file with this info. Here is an example of what I'm referring to.
https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2039/files#diff-24b1cca18e57b052dc9ad991566c9e6cc4a10a47d8528e347ddda139d1ce705e

Netail · 2024-04-04T12:07:55Z

Hi @Netail

Thank you for contributing to OTEL :)

We can leverage this PR to help effort the group is doing to update the semantic conventions. Currently we're in a step we need to use the exported strings as you did in this PR and also document which version of the semantic conventions is using.

Would you please add a section in the README file with this info. Here is an example of what I'm referring to. https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2039/files#diff-24b1cca18e57b052dc9ad991566c9e6cc4a10a47d8528e347ddda139d1ce705e

Hi @david-luna
So if I understand correctly, I have to add all of https://github.com/Netail/opentelemetry-js-contrib/blob/fix/host-metrics-bundling/packages/opentelemetry-host-metrics/src/enum.ts to https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-semantic-conventions, use the package in host-metrics (replacing the package based ones) and adding the ones used from the semantic-conventions package in the README with the table template?

Netail · 2024-04-04T13:23:51Z

Just checked regarding opentelemetry-semantic-conventions package; it fetches the specifications from opentelemetry-specification, but the specifications folder got removed in v1.21.0, so the generator is broken... :(

david-luna · 2024-04-04T13:42:44Z

Hi @david-luna So if I understand correctly, I have to add all of https://github.com/Netail/opentelemetry-js-contrib/blob/fix/host-metrics-bundling/packages/opentelemetry-host-metrics/src/enum.ts to https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-semantic-conventions, use the package in host-metrics (replacing the package based ones) and adding the ones used from the semantic-conventions package in the README with the table template?

Semantic conventions already has these enums but the package is not updated yet so no need to contribute to https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-semantic-conventions. Actually this package is generated from the models in https://github.com/open-telemetry/semantic-conventions

We need to inform which version of semantic conventions model (not package) host metrics is using and list them. In this case the package uses v1.24.0 of the model

You could add a section with this message

## Semantic Conventions

This package uses Semantic Conventions [Version 1.24.0](https://github.com/open-telemetry/semantic-conventions/tree/v1.24.0/docs/http). As for now the Semantic Conventions
are bundled in this package but eventually will be imported from `@opentelemetry/semantic-conventions` package when it is updated to latest version.
Ref: [opentelemetry-js/issues/4235](https://github.com/open-telemetry/opentelemetry-js/issues/4235)

Attributes collected:

| Attribute          | Short Description    | Notes                   |
| ------------------ | -------------------- | ----------------------- |
| `system.cpu.state` | The state of the CPU | Key: `SYSTEM_CPU_STATE` |
| ... other attributes  |

Netail · 2024-04-04T13:47:14Z

Hi @david-luna So if I understand correctly, I have to add all of https://github.com/Netail/opentelemetry-js-contrib/blob/fix/host-metrics-bundling/packages/opentelemetry-host-metrics/src/enum.ts to https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-semantic-conventions, use the package in host-metrics (replacing the package based ones) and adding the ones used from the semantic-conventions package in the README with the table template?

Semantic conventions already has these enums but the package is not updated yet so no need to contribute to https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-semantic-conventions. Actually this package is generated from the models in https://github.com/open-telemetry/semantic-conventions

We need to inform which version of semantic conventions model (not package) host metrics is using and list them. In this case the package uses v1.24.0 of the model

system https://github.com/open-telemetry/semantic-conventions/blob/v1.24.0/docs/system/system-metrics.md

process https://github.com/open-telemetry/semantic-conventions/blob/v1.24.0/docs/system/process-metrics.md

You could add a section with this message
## Semantic Conventions

This package uses Semantic Conventions [Version 1.24.0](https://github.com/open-telemetry/semantic-conventions/tree/v1.24.0/docs/http). As for now the Semantic Conventions
are bundled in this package but eventually will be imported from `@opentelemetry/semantic-conventions` package when it is updated to latest version.
Ref: [opentelemetry-js/issues/4235](https://github.com/open-telemetry/opentelemetry-js/issues/4235)

Attributes collected:

| Attribute          | Short Description    | Notes                   |
| ------------------ | -------------------- | ----------------------- |
| `system.cpu.state` | The state of the CPU | Key: `SYSTEM_CPU_STATE` |
| ... other attributes  |

Shall I pull up a PR which generates the semantic concentions from the new repo?

Netail · 2024-04-04T15:49:32Z

Updated the generator here: open-telemetry/opentelemetry-js#4606

david-luna · 2024-04-04T18:21:10Z

Updated the generator here: open-telemetry/opentelemetry-js#4606

this is indeed one of the tasks to be done for updating semantic conventions but since it a big leap in versions we expect breaking changes. This was discussed in the JavaScript SIG and planned. The plan is summarised and tracked in open-telemetry/opentelemetry-js#4572

the PR looks good but 1st we need to prepare the packages in contrib to be ready for the change. You can help us with these preparation tasks :)

Also you can join the SIG to discuss this topic and others. Here is the doc with the MoMs and also with the info to join https://docs.google.com/document/d/1tCyoQK49WVcE-x8oryZOTTToFm7sIeUhxFPm9g-qL1k/edit

Netail · 2024-04-04T19:46:49Z

Updated the generator here: open-telemetry/opentelemetry-js#4606

this is indeed one of the tasks to be done for updating semantic conventions but since it a big leap in versions we expect breaking changes. This was discussed in the JavaScript SIG and planned. The plan is summarised and tracked in open-telemetry/opentelemetry-js#4572

the PR looks good but 1st we need to prepare the packages in contrib to be ready for the change. You can help us with these preparation tasks :)

Also you can join the SIG to discuss this topic and others. Here is the doc with the MoMs and also with the info to join https://docs.google.com/document/d/1tCyoQK49WVcE-x8oryZOTTToFm7sIeUhxFPm9g-qL1k/edit

What kind of preparation do all the packages need?

Updated open-telemetry/opentelemetry-js#4606 to include v1.25.0 Semantic Conventions. As all packages within the same repo have a different version specified, we can merge that PR, and create different PRs for the packages who use the semantic-conventions package

Added the semantic conventions table to the README

packages/opentelemetry-host-metrics/README.md

packages/opentelemetry-host-metrics/src/BaseMetrics.ts

david-luna · 2024-04-05T11:44:58Z

packages/opentelemetry-host-metrics/global.d.ts

I guess with the change suggested by @pichlermarc in ./src/stats/si.ts

- import { networkStats } from 'systeminformation/lib/network'; + import { networkStats } from 'systeminformation';

this file is no needed. I see the .d.ts file from systeminformation exporting networkStats function already

When I use import { networkStats } from 'systeminformation';, it still tries to import the underlying cpu.js file, thus throwing an error on macOS. :( By targeting the file directly it won't.

The systeminformation/lib/cpu.js file tries to import osx-temperature-sensor for macOS, which you additionally have to install for macOS temperatures as it's not included in the dependencies, however osx-temp-sensor package breaks something else. But the cpu.js file isn't even used for host-metrics, so installing this package besides systeminformation is unecessary

david-luna · 2024-04-05T11:47:04Z

What kind of preparation do all the packages need?

@Netail please check open-telemetry/opentelemetry-js#4572 for more info on the update plan, thanks :)

Netail · 2024-04-16T20:04:14Z

Why "having to add"? It looks like lib/cpu.js lazily does require('osx-temperature-sensor') only if cpuTemperature() is called.

@trentm in theory yes, but when I try to use the package it somehow triggers the require ;/
When I edited the import to the file directly in my node_modules, it wouldn't complain anymore

trentm · 2024-04-17T22:11:18Z

in theory yes, but when I try to use the package it somehow triggers the require ;/

Can you run it again with NODE_DEBUG=module set? That should show the chain of requires that leads to loading that module.

Netail · 2024-04-18T08:13:38Z

Doesn't show anything relevant regarding @opentelemetry/host-metrics else besides the original stack trace;

 ⚠ ../../node_modules/systeminformation/lib/cpu.js
Module not found: Can't resolve 'osx-temperature-sensor' in '<dir>/project/node_modules/systeminformation/lib'

Import trace for requested module:
../../node_modules/systeminformation/lib/cpu.js
../../node_modules/systeminformation/lib/index.js
../../node_modules/@opentelemetry/host-metrics/build/src/stats/si.js
../../node_modules/@opentelemetry/host-metrics/build/src/metric.js
../../node_modules/@opentelemetry/host-metrics/build/src/index.js
../../packages/custom-otel/src/metrics/instrumentation.node.ts
../../packages/custom-otel/src/metrics/instrumentation.ts

trentm

@Netail

Please run 'npm run lint:fix' to update style / reflow-indentation after your changes. That is why the "Lint" check is failing.
I also got a failure in npm run compile. This fixed it for me:

--- a/packages/opentelemetry-host-metrics/src/stats/common.ts
+++ b/packages/opentelemetry-host-metrics/src/stats/common.ts
@@ -14,7 +14,8 @@
  * limitations under the License.
  */

-import { type CpuInfo, cpus, totalmem, freemem } from 'os';
+import type { CpuInfo } from 'os';
+import { cpus, totalmem, freemem } from 'os';

I don't know what you are experiencing with the osx-temperature-sensor thing. Things work fine for me (I am on macOS) after this change:

--- a/packages/opentelemetry-host-metrics/src/stats/si.ts
+++ b/packages/opentelemetry-host-metrics/src/stats/si.ts
@@ -14,10 +14,7 @@
  * limitations under the License.
  */

-// Import from network file directly as importing from the root imports the /lib/cpu file,
-// resulting in also having to add osx-temperature-sensor as a dependency for macOS,
-// while /lib/cpu isn't even used by this package (deep-importing not working as expected)
-import { networkStats } from 'systeminformation/lib/network';
+import { networkStats } from 'systeminformation';

In fact, the tests fail if I don't make that change, because the tests are currently mocking systeminformation.networkStats (see

opentelemetry-js-contrib/packages/opentelemetry-host-metrics/test/metric.test.ts

Line 140 in b903bce

sandbox.stub(SI, 'networkStats').callsFake(mockedSI.networkStats);

). That mocking doesn't work when import { networkStats } from 'systeminformation/lib/network'; is used.

Can you try with the above changes and see if npm run compile and npm test (in the packages/opentelemetry-host-metrics dir) work for you now?

If not, can you please provide more details on what exactly what commands you are running that lead to the attempt and failure to require('osx-temperature-sensor').

Netail · 2024-04-20T14:27:28Z

Thanks for the feedback @trentm ,
I fixed 1 & 2 (Interesting, 2 was related to an older version of TS as this is possible in newer versions).

3 still doesn't work for me, so I created a demo project; https://github.com/Netail/host-metrics-macos

yarn install & yarn dev to test the change
Remove the .next folder and make the change in the node_modules
Repeat step 1

Netail · 2024-04-30T09:09:58Z

@trentm were you able to reproduce the issue?

trentm · 2024-05-01T15:42:50Z

so I created a demo project; https://github.com/Netail/host-metrics-macos

Ah, Next.js. When I ran yarn install and then yarn dev the first time in your example repo, I got:

first time

% yarn dev
yarn run v1.22.22
$ next dev
  ▲ Next.js 14.2.2
  - Local:        http://localhost:3000
  - Experiments (use with caution):
    · instrumentationHook

 ✓ Starting...
Attention: Next.js now collects completely anonymous telemetry regarding usage.
This information is used to shape Next.js' roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://nextjs.org/telemetry

 ○ Compiling /instrumentation ...
 ⚠ ./node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
Critical dependency: the request of a dependency is an expression

Import trace for requested module:
./node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
./node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js
./node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js
./node_modules/@opentelemetry/instrumentation/build/esm/index.js
./instrumentation.node.ts

./node_modules/systeminformation/lib/cpu.js
Module not found: Can't resolve 'osx-temperature-sensor' in '/Users/trentm/tmp/host-metrics-macos/node_modules/systeminformation/lib'

Import trace for requested module:
./node_modules/systeminformation/lib/cpu.js
./node_modules/systeminformation/lib/index.js
./node_modules/@opentelemetry/host-metrics/build/src/stats/si.js
./node_modules/@opentelemetry/host-metrics/build/src/metric.js
./node_modules/@opentelemetry/host-metrics/build/src/index.js
./instrumentation.node.ts
TypeError: An error occurred while loading instrumentation hook: instrumentationHook.register is not a function
    at DevServer.runInstrumentationHookIfAvailable (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/dev/next-dev-server.js:437:43)
    at async Span.traceAsyncFn (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/trace/trace.js:154:20)
    at async DevServer.prepareImpl (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/dev/next-dev-server.js:214:9)
    at async NextServer.prepare (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/next.js:161:13)
    at async initializeImpl (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/lib/render-server.js:98:5)
    at async initialize (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/lib/router-server.js:423:22)
    at async Server.<anonymous> (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/lib/start-server.js:249:36)

✨  Done in 3.48s.

Which included this in the output:

./node_modules/systeminformation/lib/cpu.js
Module not found: Can't resolve 'osx-temperature-sensor' in '/Users/trentm/tmp/host-metrics-macos/node_modules/systeminformation/lib'

There is also this error output:

TypeError: An error occurred while loading instrumentation hook: instrumentationHook.register is not a function

The yarn dev exited with a 0 (i.e. success) status code. Pardon my Next.js ignorance, but is that a breakage?

After an edit to "node_modules/@opentelemetry/host-metrics/build/src/stats/si.js" to use:

const SI = require("systeminformation/lib/network");

I get:

after edit

% yarn dev
yarn run v1.22.22
$ next dev
  ▲ Next.js 14.2.2
  - Local:        http://localhost:3000
  - Experiments (use with caution):
    · instrumentationHook

 ✓ Starting...
 ○ Compiling /instrumentation ...
 ⚠ ./node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
Critical dependency: the request of a dependency is an expression

Import trace for requested module:
./node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
./node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js
./node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js
./node_modules/@opentelemetry/instrumentation/build/esm/index.js
./instrumentation.node.ts
TypeError: An error occurred while loading instrumentation hook: instrumentationHook.register is not a function
    at DevServer.runInstrumentationHookIfAvailable (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/dev/next-dev-server.js:437:43)
    at async Span.traceAsyncFn (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/trace/trace.js:154:20)
    at async DevServer.prepareImpl (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/dev/next-dev-server.js:214:9)
    at async NextServer.prepare (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/next.js:161:13)
    at async initializeImpl (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/lib/render-server.js:98:5)
    at async initialize (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/lib/router-server.js:423:22)
    at async Server.<anonymous> (/Users/trentm/tmp/host-metrics-macos/node_modules/next/dist/server/lib/start-server.js:249:36)

✨  Done in 2.01s.

This again exits with status 0, and has the TypeError: An error occurred while loading instrumentation hook: instrumentationHook.register is not a function message in the output.

Does that TypeError need to be dealt with first?

So my (limited) understanding and guess is that this is related to Next.js doing bundling?
Is that Can't resolve 'osx-temperature-sensor' message actually fatal for Next.js? Or will the Next.js app still work because we don't expect a runtime call to require('osx-temperature-sensor')?

Could the Next.js app be configured to stub out or mock that package? (I understand it would be poor of OTel JS to require Next.js users of @opentelemetry/host-metrics to have to know to do that.) I'm not that familiar with bundler issues and Next.js, so I'm trying to understand.

trentm · 2024-05-01T15:46:21Z

Could the Next.js app be configured to stub out or mock that package? (I understand it would be poor of OTel JS to require Next.js users of @opentelemetry/host-metrics to have to know to do that.) I'm not that familiar with bundler issues and Next.js, so I'm trying to understand.

See sebhildebrandt/systeminformation#701

trentm · 2024-05-01T15:54:27Z

Actually there are a bunch of (closed) issues on systeminformation:

https://github.com/sebhildebrandt/systeminformation/issues?q=osx-temperature-sensor

that all (at least the 5 or so that I read) point to this issue of getting

Module not found: Can't resolve 'osx-temperature-sensor' in '<dir>/project/node_modules/systeminformation/lib'

when using this module with webpack.

That error message is from webpack code here:
https://github.com/webpack/webpack/blob/v5.91.0/lib/ModuleNotFoundError.js#L53-L54

(Side note: There is a comment about removing that in webpack 6, for what it is worth. I'm not sure exactly what is implied by that.)

(Side note: The amount of confusion that webpack could reduce or could have reduced by just putting "webpack" in their error messages is large.)

Netail · 2024-05-01T16:25:23Z

This again exits with status 0, and has the TypeError: An error occurred while loading instrumentation hook: instrumentationHook.register is not a function message in the output.

My mistake, oopsie. Changed the function name in instrumentation.ts before pushing, should be fixed now.

But at least you were able to reproduce my issue with osx-temp. :) I think targetting the network file directly in host-metrics for now should be the better solution instead of users having to modify stuff in their webpack

@trentm what do you think?

Netail · 2024-05-01T16:42:16Z

As far as I know, instrumentation.ts is the only way currently in NextJS. (Further quite a blackbox, so not sure what happens under the hood regarding this file)

Also recommended according to the docs; https://nextjs.org/docs/app/building-your-application/optimizing/open-telemetry#manual-opentelemetry-configuration

Netail · 2024-05-02T20:10:58Z

I noticed the Module not found: Can't resolve 'osx-temperature-sensor' in '<dir>/project/node_modules/systeminformation/lib' also occurs when building the nextjs app in GitHub actions with linux runners. But only as a warning

Which uses Ubuntu 22.04.4 LTS

r34son · 2024-05-08T19:32:57Z

Getting same error:

 ✓ Starting...
 ○ Compiling /instrumentation ...
 ⚠ ./node_modules/.pnpm/systeminformation@5.22.8/node_modules/systeminformation/lib/cpu.js
Module not found: Can't resolve 'osx-temperature-sensor' in '/Users/seitasanov/ownProjects/profile/node_modules/.pnpm/systeminformation@5.22.8/node_modules/systeminformation/lib'

Import trace for requested module:
./node_modules/.pnpm/systeminformation@5.22.8/node_modules/systeminformation/lib/cpu.js
./node_modules/.pnpm/systeminformation@5.22.8/node_modules/systeminformation/lib/index.js
./node_modules/.pnpm/@opentelemetry+host-metrics@0.35.1_@opentelemetry+api@1.8.0/node_modules/@opentelemetry/host-metrics/build/src/stats/si.js
./node_modules/.pnpm/@opentelemetry+host-metrics@0.35.1_@opentelemetry+api@1.8.0/node_modules/@opentelemetry/host-metrics/build/src/metric.js
./node_modules/.pnpm/@opentelemetry+host-metrics@0.35.1_@opentelemetry+api@1.8.0/node_modules/@opentelemetry/host-metrics/build/src/index.js

r34son · 2024-05-08T19:49:06Z

@Netail You can also get rid of this message by modifying nextjs webpack config:

  webpack: (config, { webpack }) => {
    config.plugins.push(
      new webpack.IgnorePlugin({ resourceRegExp: /osx-temperature-sensor/ }),
    );
    return config;
  },

Netail · 2024-05-08T19:57:30Z

@Netail You can also get rid of this message by modifying nextjs webpack config:

  webpack: (config, { webpack }) => {
    config.plugins.push(
      new webpack.IgnorePlugin({ resourceRegExp: /osx-temperature-sensor/ }),
    );
    return config;
  },

I know, but does bloat your next config. Would prefer a solution to mitigate this closer at the source and removes the error for everyone at once

fix: semcov alignment & reduce import bundle

2c6d8cf

Netail requested a review from a team as a code owner March 30, 2024 00:00

github-actions bot assigned legendecas Mar 30, 2024

github-actions bot requested a review from legendecas March 30, 2024 00:00

github-actions bot added the pkg:host-metrics label Mar 30, 2024

pichlermarc reviewed Apr 2, 2024

View reviewed changes

Netail added 3 commits April 2, 2024 16:08

fix: types?

60e0933

Merge branch 'main' into fix/host-metrics-bundling

65aabe7

fix: ci/cd

ae578fc

Merge branch 'main' into fix/host-metrics-bundling

ce92ffe

Netail requested a review from pichlermarc April 2, 2024 21:28

Netail added 2 commits April 3, 2024 15:51

Merge branch 'main' into fix/host-metrics-bundling

e818ba5

Merge branch 'main' into fix/host-metrics-bundling

2484ef6

docs: specify semantic conventions

1106e97

david-luna reviewed Apr 5, 2024

View reviewed changes

Netail force-pushed the fix/host-metrics-bundling branch from 0b09d19 to f28832f Compare April 5, 2024 11:55

revert some changes

8f65520

Netail force-pushed the fix/host-metrics-bundling branch from f28832f to 8f65520 Compare April 5, 2024 11:58

Merge branch 'main' into fix/host-metrics-bundling

08506a4

Merge branch 'main' into fix/host-metrics-bundling

d1c1fca

trentm requested changes Apr 19, 2024

View reviewed changes

Netail added 2 commits April 20, 2024 16:01

Merge branch 'main' into fix/host-metrics-bundling

a3b898f

fix: feedback

a8196e4

Merge branch 'main' into fix/host-metrics-bundling

304dc98

Netail requested a review from trentm April 24, 2024 08:41

Netail added 3 commits April 28, 2024 01:01

Merge branch 'main' into fix/host-metrics-bundling

9f81a2d

Merge branch 'main' into fix/host-metrics-bundling

769de9e

Merge branch 'main' into fix/host-metrics-bundling

4fd1f8f

Merge branch 'main' into fix/host-metrics-bundling

9c30315

Merge branch 'main' into fix/host-metrics-bundling

83c58a3

Netail added 4 commits May 2, 2024 22:23

Merge branch 'main' into fix/host-metrics-bundling

2ac772e

Merge branch 'main' into fix/host-metrics-bundling

343733e

Merge branch 'main' into fix/host-metrics-bundling

fd50fe5

Merge branch 'main' into fix/host-metrics-bundling

38b80b1

Merge branch 'main' into fix/host-metrics-bundling

b642766

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(host-metrics): semcov alignment & macOS fix #2071

fix(host-metrics): semcov alignment & macOS fix #2071

Netail commented Mar 30, 2024 •

edited

linux-foundation-easycla bot commented Mar 30, 2024 •

edited

pichlermarc Apr 2, 2024

Netail Apr 9, 2024 •

edited

trentm Apr 16, 2024

Netail commented Apr 2, 2024 •

edited

david-luna commented Apr 4, 2024

Netail commented Apr 4, 2024 •

edited

Netail commented Apr 4, 2024 •

edited

david-luna commented Apr 4, 2024

Netail commented Apr 4, 2024 •

edited

Netail commented Apr 4, 2024

david-luna commented Apr 4, 2024

Netail commented Apr 4, 2024 •

edited

david-luna Apr 5, 2024

Netail Apr 5, 2024 •

edited

david-luna commented Apr 5, 2024

Netail commented Apr 16, 2024 •

edited

trentm commented Apr 17, 2024

Netail commented Apr 18, 2024 •

edited

trentm left a comment

Netail commented Apr 20, 2024 •

edited

Netail commented Apr 30, 2024

trentm commented May 1, 2024

trentm commented May 1, 2024

trentm commented May 1, 2024

Netail commented May 1, 2024 •

edited

Netail commented May 1, 2024 •

edited

Netail commented May 2, 2024 •

edited

r34son commented May 8, 2024

r34son commented May 8, 2024

Netail commented May 8, 2024 •

edited

	import { networkStats } from 'systeminformation/lib/network';
	import { networkStats } from 'systeminformation';

fix(host-metrics): semcov alignment & macOS fix #2071

Are you sure you want to change the base?

fix(host-metrics): semcov alignment & macOS fix #2071

Conversation

Netail commented Mar 30, 2024 • edited

Which problem is this PR solving?

Short description of the changes

linux-foundation-easycla bot commented Mar 30, 2024 • edited

pichlermarc Apr 2, 2024

Choose a reason for hiding this comment

Netail Apr 9, 2024 • edited

Choose a reason for hiding this comment

trentm Apr 16, 2024

Choose a reason for hiding this comment

Netail commented Apr 2, 2024 • edited

david-luna commented Apr 4, 2024

Netail commented Apr 4, 2024 • edited

Netail commented Apr 4, 2024 • edited

david-luna commented Apr 4, 2024

Netail commented Apr 4, 2024 • edited

Netail commented Apr 4, 2024

david-luna commented Apr 4, 2024

Netail commented Apr 4, 2024 • edited

david-luna Apr 5, 2024

Choose a reason for hiding this comment

Netail Apr 5, 2024 • edited

Choose a reason for hiding this comment

david-luna commented Apr 5, 2024

Netail commented Apr 16, 2024 • edited

trentm commented Apr 17, 2024

Netail commented Apr 18, 2024 • edited

trentm left a comment

Choose a reason for hiding this comment

Netail commented Apr 20, 2024 • edited

Netail commented Apr 30, 2024

trentm commented May 1, 2024

trentm commented May 1, 2024

trentm commented May 1, 2024

Netail commented May 1, 2024 • edited

Netail commented May 1, 2024 • edited

Netail commented May 2, 2024 • edited

r34son commented May 8, 2024

r34son commented May 8, 2024

Netail commented May 8, 2024 • edited

Netail commented Mar 30, 2024 •

edited

linux-foundation-easycla bot commented Mar 30, 2024 •

edited

Netail Apr 9, 2024 •

edited

Netail commented Apr 2, 2024 •

edited

Netail commented Apr 4, 2024 •

edited

Netail commented Apr 4, 2024 •

edited

Netail commented Apr 4, 2024 •

edited

Netail commented Apr 4, 2024 •

edited

Netail Apr 5, 2024 •

edited

Netail commented Apr 16, 2024 •

edited

Netail commented Apr 18, 2024 •

edited

Netail commented Apr 20, 2024 •

edited

Netail commented May 1, 2024 •

edited

Netail commented May 1, 2024 •

edited

Netail commented May 2, 2024 •

edited

Netail commented May 8, 2024 •

edited