chore: refactoring zipkin to be able to use it in web #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1399 +/- ##
=======================================
Coverage 93.81% 93.82%
=======================================
Files 153 154 +1
Lines 4756 4762 +6
Branches 951 951
=======================================
+ Hits 4462 4468 +6
Misses 294 294
|
|
Hello, I see a little something that looks off, if the response is a bad request (status code 400), the export will still be marked as success. |
dyladan
reviewed
Aug 18, 2020
packages/opentelemetry-exporter-zipkin/src/platform/browser/util.ts
Outdated
Show resolved
Hide resolved
dyladan
approved these changes
Aug 18, 2020
|
@open-telemetry/javascript-approvers this has been around a while and is a fairly safe change that has been requested multiple times |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…#1399) Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes