Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change CollectorExporter to CollectorTraceExporter #1483

Merged
merged 1 commit into from
Sep 2, 2020
Merged

docs: change CollectorExporter to CollectorTraceExporter #1483

merged 1 commit into from
Sep 2, 2020

Conversation

hongbo-miao
Copy link
Contributor

Which problem is this PR solving?

  • Early pull request has renamed CollectorExporter to CollectorTraceExporter, this corrects the doc wrong API.

Short description of the changes

  • change CollectorExporter to CollectorTraceExporter

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1483 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1483   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files         153      153           
  Lines        4656     4656           
  Branches      959      959           
=======================================
  Hits         4381     4381           
  Misses        275      275           

@dyladan dyladan merged commit c70dabf into open-telemetry:master Sep 2, 2020
@dyladan dyladan added the document Documentation-related label Sep 2, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Co-authored-by: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants