fix: avoid circular require in plugins #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
dyladan
force-pushed
the
avoid-circular-require
branch
from
935d963
to
33e1f7e
Compare
naseemkullah
approved these changes
Sep 22, 2020
dyladan
force-pushed
the
avoid-circular-require
branch
from
33e1f7e
to
fd2d629
Compare
Codecov Report
@@ Coverage Diff @@
## master #1551 +/- ##
==========================================
- Coverage 93.11% 93.11% -0.01%
==========================================
Files 155 154 -1
Lines 4811 4807 -4
Branches 971 971
==========================================
- Hits 4480 4476 -4
Misses 331 331
|
vmarchaud
approved these changes
Sep 22, 2020
markwolff
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1461