Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement parent based sampler #1577

Merged
merged 11 commits into from
Oct 13, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 7, 2020

Fixes #1455

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #1577 into master will increase coverage by 2.93%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
+ Coverage   88.47%   91.41%   +2.93%     
==========================================
  Files         116      165      +49     
  Lines        2387     5055    +2668     
  Branches      447     1035     +588     
==========================================
+ Hits         2112     4621    +2509     
- Misses        275      434     +159     
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/utility.ts 100.00% <ø> (ø)
...metry-core/src/trace/sampler/ParentBasedSampler.ts 83.33% <83.33%> (ø)
...ges/opentelemetry-exporter-jaeger/src/transform.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-exporter-collector/src/util.ts 100.00% <0.00%> (ø)
...s/opentelemetry-plugin-xml-http-request/src/xhr.ts 97.23% <0.00%> (ø)
...y-plugin-grpc-js/src/server/serverStreamAndBidi.ts 100.00% <0.00%> (ø)
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 85.71% <0.00%> (ø)
...elemetry-exporter-zipkin/src/platform/node/util.ts 96.96% <0.00%> (ø)
...telemetry-node/src/instrumentation/PluginLoader.ts 93.82% <0.00%> (ø)
... and 42 more

GA Burndown automation moved this from In progress PRs to Approved Oct 9, 2020
@dyladan dyladan merged commit be720b4 into open-telemetry:master Oct 13, 2020
GA Burndown automation moved this from Approved to Done Oct 13, 2020
@dyladan dyladan deleted the parent-or-else branch October 13, 2020 16:39
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
GA Burndown
  
Done
Development

Successfully merging this pull request may close these issues.

Rename ParentOrElse to ParentBased and generalize to support all cases
5 participants