chore: remove duplicate hostname resource attribute #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
mwear
added
breaking
size/S
Codecov Report
@@ Coverage Diff @@
## master #1581 +/- ##
==========================================
- Coverage 93.03% 92.64% -0.39%
==========================================
Files 161 157 -4
Lines 4938 4325 -613
Branches 995 833 -162
==========================================
- Hits 4594 4007 -587
+ Misses 344 318 -26 |
dyladan
approved these changes
Oct 8, 2020
vmarchaud
approved these changes
Oct 8, 2020
obecny
approved these changes
Oct 9, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…-detector-alibaba-cloud (open-telemetry#1581) * chore: upgrade nock@13.3.1 and re-enable test in node@18 for resource-detector-alibaba-cloud * chore: remove --ignore @opentelemetry/resource-detector-alibaba-cloud in tav pipeline --------- Co-authored-by: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com> Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
host.nameandhost.hostname. This PR removes the latter as per: Remove duplicate hostname attribute opentelemetry-specification#838.