Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add fields operation to TextMapPropagator #1615

Merged
merged 7 commits into from
Oct 28, 2020
Merged

chore: add fields operation to TextMapPropagator #1615

merged 7 commits into from
Oct 28, 2020
+167 −0

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 21, 2020

Fixes #1485

@dyladan dyladan added the enhancement New feature or request label Oct 21, 2020
@dyladan dyladan added this to In progress PRs in GA Burndown via automation Oct 21, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020 •
edited

Codecov Report

Merging #1615 into master will increase coverage by 0.02%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #1615      +/-   ##
==========================================
+ Coverage   91.19%   91.22%   +0.02%     
==========================================
  Files         165      161       -4     
  Lines        5034     4727     -307     
  Branches     1026      963      -63     
==========================================
- Hits         4591     4312     -279     
+ Misses        443      415      -28
Impacted Files Coverage Δ
...y-api/src/context/propagation/TextMapPropagator.ts 14.28% <ø> (ø)
...i/src/context/propagation/NoopTextMapPropagator.ts 75.00% <50.00%> (-8.34%) ⬇️
...y-core/src/context/propagation/HttpTraceContext.ts 100.00% <100.00%> (ø)
...elemetry-core/src/context/propagation/composite.ts 100.00% <100.00%> (ø)
...tion-context/propagation/HttpCorrelationContext.ts 98.11% <100.00%> (+0.07%) ⬆️
...entelemetry-propagator-b3/src/B3MultiPropagator.ts 100.00% <100.00%> (ø)
...es/opentelemetry-propagator-b3/src/B3Propagator.ts 100.00% <100.00%> (ø)
...ntelemetry-propagator-b3/src/B3SinglePropagator.ts 100.00% <100.00%> (ø)
packages/opentelemetry-plugin-grpc/src/grpc.ts
packages/opentelemetry-plugin-grpc/src/utils.ts
... and 2 more

GA Burndown automation moved this from In progress PRs to Approved Oct 26, 2020
@dyladan dyladan merged commit eb35306 into open-telemetry:master Oct 28, 2020
GA Burndown automation moved this from Approved to Done Oct 28, 2020
@dyladan dyladan deleted the propagator-fields branch October 28, 2020 13:10
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@dyladan
chore: add fields operation to TextMapPropagator (open-telemetry#1615)
6588aac
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@dyladan
chore: add fields operation to TextMapPropagator (open-telemetry#1615)
0e4e4f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 left review comments

@obecny obecny obecny approved these changes

@mwear mwear mwear approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@legendecas legendecas Awaiting requested review from legendecas

@markwolff markwolff Awaiting requested review from markwolff

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
GA Burndown
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TextMapPropagator Fields
5 participants
@dyladan @obecny @mwear @vmarchaud @mayurkale22