chore: fixing conversion of id to hex and base64 #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
==========================================
- Coverage 91.21% 91.21% -0.01%
==========================================
Files 165 165
Lines 5053 5064 +11
Branches 1027 1038 +11
==========================================
+ Hits 4609 4619 +10
- Misses 444 445 +1
|
dyladan
approved these changes
Oct 28, 2020
mwear
approved these changes
Oct 28, 2020
vmarchaud
approved these changes
Oct 29, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…pen-telemetry#1627) * feat(lambda): Adds lambdaHandler config option * Apply suggestions from code review Co-authored-by: Amir Blum <amirgiraffe@gmail.com> * Apply suggestions from code review Co-authored-by: Carol Abadeer <60774943+carolabadeer@users.noreply.github.com> * Update README.md --------- Co-authored-by: Amir Blum <amirgiraffe@gmail.com> Co-authored-by: Carol Abadeer <60774943+carolabadeer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes