Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sampler gets a full context #1631

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 28, 2020

Fixes #1630

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1631 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
+ Coverage   91.19%   91.22%   +0.02%     
==========================================
  Files          69      165      +96     
  Lines        1784     5070    +3286     
  Branches      375     1039     +664     
==========================================
+ Hits         1627     4625    +2998     
- Misses        157      445     +288     
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/Tracer.ts 98.33% <ø> (ø)
...metry-core/src/trace/sampler/ParentBasedSampler.ts 83.87% <100.00%> (+0.53%) ⬆️
...core/src/trace/sampler/TraceIdRatioBasedSampler.ts 100.00% <100.00%> (ø)
...ry-exporter-prometheus/src/PrometheusSerializer.ts 97.84% <0.00%> (ø)
packages/opentelemetry-metrics/src/Metric.ts 97.22% <0.00%> (ø)
packages/opentelemetry-resources/src/Resource.ts 100.00% <0.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (ø)
packages/opentelemetry-plugin-http/src/utils.ts 97.36% <0.00%> (ø)
...s/opentelemetry-metrics/src/BatchObserverMetric.ts 93.10% <0.00%> (ø)
...telemetry-plugin-grpc-js/src/server/patchServer.ts 88.52% <0.00%> (ø)
... and 94 more

GA Burndown automation moved this from In progress PRs to Approved Oct 29, 2020
@obecny obecny added the enhancement New feature or request label Oct 30, 2020
@dyladan dyladan merged commit 5921901 into open-telemetry:master Oct 30, 2020
GA Burndown automation moved this from Approved to Done Oct 30, 2020
@Flarna Flarna deleted the context-sampler branch November 30, 2020 11:39
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
GA Burndown
  
Done
Development

Successfully merging this pull request may close these issues.

spec: sampler should receive Context instead of SpanContext
3 participants