Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: span processor onstart recieves context #1632

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 28, 2020

Fixes #1613

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1632 into master will increase coverage by 1.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
+ Coverage   90.86%   92.30%   +1.43%     
==========================================
  Files         151      147       -4     
  Lines        4358     4653     +295     
  Branches      885      956      +71     
==========================================
+ Hits         3960     4295     +335     
+ Misses        398      358      -40     
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/Tracer.ts 98.33% <ø> (ø)
...s/opentelemetry-tracing/src/BasicTracerProvider.ts 77.77% <100.00%> (ø)
...es/opentelemetry-tracing/src/MultiSpanProcessor.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 42.85% <100.00%> (ø)
packages/opentelemetry-tracing/src/Span.ts 98.09% <100.00%> (ø)
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
.../opentelemetry-api/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...ckages/opentelemetry-core/src/common/NoopLogger.ts 40.00% <0.00%> (-20.00%) ⬇️
packages/opentelemetry-propagator-b3/src/common.ts
... and 31 more

GA Burndown automation moved this from In progress PRs to Approved Oct 28, 2020
@obecny obecny added the enhancement New feature or request label Oct 30, 2020
@dyladan dyladan merged commit d8907d8 into open-telemetry:master Oct 30, 2020
GA Burndown automation moved this from Approved to Done Oct 30, 2020
@Flarna Flarna deleted the onstart-context branch November 30, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
GA Burndown
  
Done
Development

Successfully merging this pull request may close these issues.

Spec: SpanProcessor.onStart should receive parent context
4 participants