chore: env vars for span limit as per specification #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmalinowski
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
vmarchaud
reviewed
Nov 6, 2020
vmarchaud
approved these changes
Nov 6, 2020
|
@vmarchaud are you asking about https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-tracing/test/Span.test.ts#L330 or something else? |
|
@jtmalinowski Yeah that was my question, thanks for the link ! |
naseemkullah
approved these changes
Nov 6, 2020
mayurkale22
approved these changes
Nov 6, 2020
mwear
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
LGTM, although, I'll note that this significantly increases the default limits.
- max events per span was 128; now 1000
- attributes per span was 32; now 1000
- links per span was 32; now 1000
It is in line with the environment variable spec, however.
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes