Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replacing base plugin with instrumentation for xml-http-request #1659

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented Nov 6, 2020

Which problem is this PR solving?

Short description of the changes

  • Using Instrumentation instead of BasePlugin
  • small changes to Instrumentation
  • Updating WebTracerProvider to support old plugins and new instrumentation

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1659 (14bc751) into master (b703f9f) will decrease coverage by 0.00%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
- Coverage   91.36%   91.35%   -0.01%     
==========================================
  Files         165      165              
  Lines        5037     5043       +6     
  Branches     1039     1040       +1     
==========================================
+ Hits         4602     4607       +5     
- Misses        435      436       +1     
Impacted Files Coverage Δ
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <ø> (ø)
...entelemetry-instrumentation/src/instrumentation.ts 63.63% <ø> (ø)
...strumentation/src/platform/node/instrumentation.ts 6.94% <ø> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 96.72% <95.23%> (ø)
...ackages/opentelemetry-web/src/WebTracerProvider.ts 100.00% <100.00%> (ø)

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obecny obecny merged commit 97736be into open-telemetry:master Nov 10, 2020
@obecny obecny deleted the xhr branch November 10, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert XMLHttpRequest plugin to instrumentation
4 participants