Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear BatchSpanProcessor internal spans buffer before exporting #1666

Conversation

TsvetanMilanov
Copy link
Contributor

@TsvetanMilanov TsvetanMilanov commented Nov 10, 2020

Which problem is this PR solving?

Short description of the changes

  • The PR ensures that the internal spans buffer of the BatchSpanProcessor is cleared before another invocation
    of the _flush method is started.

@linux-foundation-easycla
Copy link

CLA Not Signed

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #1666 (17e0d74) into master (97736be) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
- Coverage   91.35%   91.35%   -0.01%     
==========================================
  Files         165      165              
  Lines        5043     5042       -1     
  Branches     1040     1040              
==========================================
- Hits         4607     4606       -1     
  Misses        436      436              
Impacted Files Coverage Δ
...telemetry-tracing/src/export/BatchSpanProcessor.ts 90.76% <100.00%> (-0.14%) ⬇️

@TsvetanMilanov TsvetanMilanov force-pushed the fix/batch-span-processor-duplicate-spans branch from cc4b37a to bcec1bc Compare November 10, 2020 15:34
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx

@dyladan dyladan added the bug Something isn't working label Nov 10, 2020
@dyladan dyladan merged commit 25a2f65 into open-telemetry:master Nov 10, 2020
@TsvetanMilanov TsvetanMilanov deleted the fix/batch-span-processor-duplicate-spans branch November 11, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchSpanProcessor exports spans multiple times
4 participants