fix(api): add public 'fields' function to api.propagator #1813
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
dyladan
approved these changes
Jan 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #1813 +/- ##
==========================================
+ Coverage 92.44% 92.51% +0.07%
==========================================
Files 171 173 +2
Lines 5913 6038 +125
Branches 1264 1284 +20
==========================================
+ Hits 5466 5586 +120
- Misses 447 452 +5
|
obecny
approved these changes
Jan 13, 2021
obecny
reviewed
Jan 13, 2021
mwear
approved these changes
Jan 13, 2021
vmarchaud
approved these changes
Jan 13, 2021
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
…try#1813) * fix(api): add public 'fields' function to api.propagator * chore: remove redundant comment Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
…try#1813) * fix(api): add public 'fields' function to api.propagator * chore: remove redundant comment Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
fieldsfunction toapi.propagator, which callsfieldsfunction on the global propagator and return the result