chore: fixing status code aligning it with proto #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1860 +/- ##
==========================================
+ Coverage 92.39% 92.52% +0.12%
==========================================
Files 170 172 +2
Lines 5733 5846 +113
Branches 1235 1254 +19
==========================================
+ Hits 5297 5409 +112
- Misses 436 437 +1
|
mwear
approved these changes
Jan 21, 2021
Flarna
approved these changes
Jan 21, 2021
vmarchaud
approved these changes
Jan 22, 2021
johnbley
approved these changes
Jan 22, 2021
naseemkullah
approved these changes
Jan 24, 2021
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
redis@4.6.9 was a bad release that accidentally broken v14 support. This updates the versions test to skip that release, and also reduces the number of versions tested from 27 to 8 by selecting just the current latest minor releases. Also, drop the pretest config that (a) was never used because of the wrong indentation and (b) is no longer valid since the move to npm workspaces. Refs: open-telemetry#1860
pichlermarc
added a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
The beforeEach() hook was not awaited, so afterEach() could run before it completed, resulting in a client.disconnect() that rejects, and a mocha hook that calls done() twice. Refs: open-telemetry#1860 Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
pichlermarc
added a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…telemetry#1861) This tests just the latest in each minor version. Refs: open-telemetry#1860 Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Aligning api StatusCode with proto format to avoid any future bugs and other problems.
Currently span status is
0 - OK
1 - Unset
2 - Error
Proto defines this as
0 - Unset
1 - OK
2 - Error
This PR changes Status as in proto