Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint on shadowing in non-test sources, fix a few of them #1922

Merged
merged 5 commits into from
Feb 20, 2021
Merged

chore: lint on shadowing in non-test sources, fix a few of them #1922

merged 5 commits into from
Feb 20, 2021

Conversation

johnbley
Copy link
Member

Fixes #1882. As suggested, this is only a lint warning, not an error, due to some false positives. Additionally, since so
many spurious warnings were given for it blocks in tests, disable the rule for test sources.

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #1922 (22e5f7c) into main (16c941d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
+ Coverage   92.74%   92.75%   +0.01%     
==========================================
  Files         174      177       +3     
  Lines        6108     6200      +92     
  Branches     1265     1291      +26     
==========================================
+ Hits         5665     5751      +86     
- Misses        443      449       +6     
Impacted Files Coverage Δ
...emetry-core/src/baggage/propagation/HttpBaggage.ts 98.21% <100.00%> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts 95.51% <100.00%> (+0.81%) ⬆️
packages/opentelemetry-metrics/src/Meter.ts 88.59% <100.00%> (ø)
packages/opentelemetry-plugin-http/src/http.ts 97.31% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...-instrumentation-fetch/src/enums/AttributeNames.ts
...ntelemetry-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-web/src/StackContextManager.ts 97.05% <0.00%> (ø)
packages/opentelemetry-web/src/utils.ts 94.66% <0.00%> (ø)
... and 4 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one suggestion hope you can address it before merging

packages/opentelemetry-metrics/src/Meter.ts Outdated Show resolved Hide resolved
@obecny
Copy link
Member

obecny commented Feb 17, 2021

@johnbley can you please resolve conflicts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve linting to add @typescript-eslint/no-shadow
6 participants