Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: url validation & README to prevent gRPC footguns. #2130

Merged
merged 15 commits into from May 3, 2021
Merged

chore: url validation & README to prevent gRPC footguns. #2130

merged 15 commits into from May 3, 2021

Commits on Apr 30, 2021

  1. extend README and url validation to avoid footguns.

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    3644ac4 View commit details
    Browse the repository at this point in the history

  2. deal with grpc(s) while here

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    7ebf326 View commit details
    Browse the repository at this point in the history

  3. fix tests by moving serverAddress checks earlier

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    e26cfed View commit details
    Browse the repository at this point in the history

  4. un-private so util can access

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    d838c47 View commit details
    Browse the repository at this point in the history

  5. Update packages/opentelemetry-exporter-collector-grpc/src/CollectorEx… 

    …porterNodeBase.ts

Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
    @lizthegrey @Flarna
    lizthegrey and Flarna committed Apr 30, 2021
    Copy the full SHA
    8d3d793 View commit details
    Browse the repository at this point in the history

  6. s#grpc#@grpc/grpc-js#

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    368ff76 View commit details
    Browse the repository at this point in the history

  7. address review feedback.

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    9ef56a0 View commit details
    Browse the repository at this point in the history

  8. fix lint and nullcheck

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    19a4bd3 View commit details
    Browse the repository at this point in the history

  9. I hate prettier --fix

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    066b283 View commit details
    Browse the repository at this point in the history

  10. address review feedback.

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    ca71abf View commit details
    Browse the repository at this point in the history

  11. my prettier config has diverged :(

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    0c584ed View commit details
    Browse the repository at this point in the history

  12. address lint & review feedback.

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    9821727 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into lizf.update-grpc-docs

    @lizthegrey
    lizthegrey committed Apr 30, 2021
    Copy the full SHA
    71db080 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Merge branch 'main' into lizf.update-grpc-docs

    @lizthegrey
    lizthegrey committed May 3, 2021
    Copy the full SHA
    e55404b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into lizf.update-grpc-docs

    @lizthegrey
    lizthegrey committed May 3, 2021
    Copy the full SHA
    ea638cc View commit details
    Browse the repository at this point in the history