chore: upgrading to api ver. 0.20.0 #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2225 +/- ##
==========================================
- Coverage 92.72% 92.28% -0.44%
==========================================
Files 142 142
Lines 5124 5146 +22
Branches 1050 1062 +12
==========================================
- Hits 4751 4749 -2
- Misses 373 397 +24
|
dyladan
approved these changes
May 24, 2021
|
Thanks this looks like it was quite a bit of work. |
Flarna
approved these changes
May 24, 2021
| @@ -29,7 +29,7 @@ import { TimedEvent } from '../TimedEvent'; | |||
| export interface ReadableSpan { | |||
| readonly name: string; | |||
| readonly kind: SpanKind; | |||
| readonly spanContext: SpanContext; | |||
| readonly spanContext: () => SpanContext; | |||
There was a problem hiding this comment.
Suggested change
| readonly spanContext: () => SpanContext; | |
| spanContext(): SpanContext; |
I find this more readable and it is in sync with the API Span interface
| propagation, | ||
| setSpan, | ||
| getSpan, | ||
| propagation, trace, |
There was a problem hiding this comment.
Seems some lint setting has change recently. Same on a few other places.
I don't care much about this so feel free to keep.
vmarchaud
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore Tracer.ts -> startActiveSpan, I just took it from api, but once this PR is reviewed and merged ->
#2221
It will supersede the one I added (copy paste from api)