Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ComponentLogger into instrumentations #2261

Merged
merged 6 commits into from Jun 9, 2021
Merged

Conversation

obecny
Copy link
Member

@obecny obecny commented Jun 7, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #2261 (15eec9f) into main (3d98420) will decrease coverage by 0.07%.
The diff coverage is 94.87%.

❗ Current head 15eec9f differs from pull request most recent head ee3bccc. Consider uploading reports for the commit ee3bccc to get more accurate results

@@            Coverage Diff             @@
##             main    #2261      +/-   ##
==========================================
- Coverage   92.79%   92.72%   -0.08%     
==========================================
  Files         144      144              
  Lines        5178     5179       +1     
  Branches     1060     1060              
==========================================
- Hits         4805     4802       -3     
- Misses        373      377       +4     
Impacted Files Coverage Δ
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.98% <75.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 96.58% <85.71%> (ø)
...elemetry-instrumentation-grpc/src/grpc-js/index.ts 90.81% <100.00%> (ø)
...entelemetry-instrumentation-grpc/src/grpc/index.ts 93.04% <100.00%> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts 94.90% <100.00%> (-0.79%) ⬇️
...entelemetry-instrumentation/src/instrumentation.ts 70.37% <100.00%> (+1.13%) ⬆️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...kages/opentelemetry-node/src/NodeTracerProvider.ts 95.83% <0.00%> (-4.17%) ⬇️
...etry-exporter-prometheus/src/PrometheusExporter.ts 90.66% <0.00%> (-1.34%) ⬇️
... and 1 more

@weyert
Copy link
Contributor

weyert commented Jun 9, 2021

Is this change related to the log spec?

@vmarchaud
Copy link
Member

Is this change related to the log spec?

nope, just to be able to debug which component is emitting logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants