Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service.name resource attribute #2290

Merged
merged 8 commits into from Jun 25, 2021
Merged

Commits on Jun 17, 2021

  1. fix: service.name Resource attribute

    Since the 0.20.0 release and the pull request open-telemetry#2227 it seems that serviceName is deprecated and we should use service.name instead. I havn't easily found this information in the changelog, it did require some digging to understand why the service name was now a very long unknown_service:/path/to/node. Documentation says use service.name Resource attribute instead. but it wasn't about replacing serviceName: 'yourServiceName' by service: { name: 'yourServiceName'}.
    OmkarKirpan committed Jun 17, 2021
    Copy the full SHA
    3987ef6 View commit details
    Browse the repository at this point in the history
  2. chore: remove service name option

    removes service name option passed in exporter
    OmkarKirpan committed Jun 17, 2021
    Copy the full SHA
    82ae64d View commit details
    Browse the repository at this point in the history
  3. style: fix lint errors

    OmkarKirpan committed Jun 17, 2021
    Copy the full SHA
    ef6363d View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    992190b View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Copy the full SHA
    7bb3231 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Copy the full SHA
    9087e7e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Copy the full SHA
    38c9b24 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. style: fix lint errors

    OmkarKirpan committed Jun 25, 2021
    Copy the full SHA
    e488608 View commit details
    Browse the repository at this point in the history