Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding Rauno56 to js approvers #2366

Merged
merged 3 commits into from Jul 22, 2021
Merged

Conversation

obecny
Copy link
Member

@obecny obecny commented Jul 20, 2021

I wanted to promote @rauno56 to js approver. He has been contributing for this project for a while and is quite active in otel as well.

PRs:
https://github.com/open-telemetry/opentelemetry-js-contrib/commits?author=Rauno56
https://github.com/open-telemetry/opentelemetry-js/commits?author=Rauno56
https://github.com/open-telemetry/opentelemetry-js-api/commits?author=Rauno56

Thx @rauno56 for all of you contributions so far.

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #2366 (2f04748) into main (39c6ea5) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2366      +/-   ##
==========================================
+ Coverage   92.76%   92.79%   +0.03%     
==========================================
  Files         145      145              
  Lines        5221     5221              
  Branches     1070     1070              
==========================================
+ Hits         4843     4845       +2     
+ Misses        378      376       -2     
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/Span.ts 98.07% <0.00%> (+0.96%) ⬆️
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to have you onboard @rauno56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants