Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update doc identifier names in readme #2399

Merged
merged 3 commits into from Aug 7, 2021
Merged

chore: update doc identifier names in readme #2399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0fc441
Update some docs
srikanthccv Aug 4, 2021
1ac4b6f
Merge branch 'main' into update-docs
srikanthccv Aug 4, 2021
f6fa488
Merge branch 'main' into update-docs
srikanthccv Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/opentelemetry-resources/README.md
View file
Open in desktop
Expand Up @@ -25,11 +25,11 @@ const resource = new Resource({
[SemanticResourceAttributes.SERVICE_NAME]: 'api-service',
});

const another_resource = new Resource({
'service.version': 2.0.0,
const anotherResource = new Resource({
'service.version': '2.0.0',
'service.group': 'instrumentation-group'
});
const merged_resource = resource.merge(another_resource);
const mergedResource = resource.merge(anotherResource);
```

## Useful links
Expand Down
4 changes: 2 additions & 2 deletions packages/opentelemetry-semantic-conventions/README.md
View file
Open in desktop
Expand Up @@ -16,11 +16,11 @@ npm install --save @opentelemetry/semantic-conventions
## Usage

```ts
import { GeneralAttribute } from '@opentelemetry/semantic-conventions';
import { SemanticAttributes } from '@opentelemetry/semantic-conventions';

const span = tracer.startSpan().startSpan(spanName, spanOptions)
.setAttributes({
[GeneralAttribute.NET_PEER_HOSTNAME]: 'localhost',
[SemanticAttributes.NET_PEER_NAME]: 'localhost',
});
```

Expand Down