Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-node): fix lint warnings #2453

Merged
merged 2 commits into from Sep 4, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/opentelemetry-sdk-node/src/sdk.ts
Expand Up @@ -111,7 +111,7 @@ export class NodeSDK {
spanProcessor: SpanProcessor,
contextManager?: ContextManager,
textMapPropagator?: TextMapPropagator
) {
): void {
this._tracerProviderConfig = {
tracerConfig,
spanProcessor,
Expand All @@ -121,12 +121,12 @@ export class NodeSDK {
}

/** Set configurations needed to register a MeterProvider */
public configureMeterProvider(config: MeterConfig) {
public configureMeterProvider(config: MeterConfig): void {
this._meterProviderConfig = config;
}

/** Detect resource attributes */
public async detectResources(config?: ResourceDetectionConfig) {
public async detectResources(config?: ResourceDetectionConfig): Promise<void> {
const internalConfig: ResourceDetectionConfig = {
detectors: [awsEc2Detector, gcpDetector, envDetector, processDetector],
...config,
Expand All @@ -136,14 +136,14 @@ export class NodeSDK {
}

/** Manually add a resource */
public addResource(resource: Resource) {
public addResource(resource: Resource): void {
this._resource = this._resource.merge(resource);
}

/**
* Once the SDK has been configured, call this method to construct SDK components and register them with the OpenTelemetry API.
*/
public async start() {
public async start(): Promise<void> {
if (this._autoDetectResources) {
await this.detectResources();
}
Expand Down