Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split stable and experimental packages into groups using directories #2462

Merged
merged 15 commits into from Sep 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
61 changes: 0 additions & 61 deletions .github/workflows/canary.yaml

This file was deleted.

14 changes: 13 additions & 1 deletion .github/workflows/lint.yml
Expand Up @@ -8,12 +8,19 @@ on:

jobs:
build:
strategy:
fail-fast: false
matrix:
package-group: [".", "experimental"]
runs-on: ubuntu-latest
container:
image: node:14

steps:
- uses: actions/checkout@v2

- name: Lint changelog file
if: ${{ matrix.package-group == '.' }}
uses: avto-dev/markdown-lint@v1
with:
# Commenting due to
Expand All @@ -24,6 +31,7 @@ jobs:
args: "./CHANGELOG.md"

- name: Lint markdown files
if: ${{ matrix.package-group == '.' }}
uses: avto-dev/markdown-lint@v1
with:
args: "./**/*.md -i ./CHANGELOG.md"
Expand All @@ -34,17 +42,21 @@ jobs:
with:
path: |
node_modules
experimental/node_modules
*/*/node_modules
key: lint-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }}
experimental/*/*/node_modules
key: lint-${{ matrix.package-group }}-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }}-20211009.2

# On a cache miss, install dependencies
- name: Bootstrap
if: steps.cache.outputs.cache-hit != 'true'
working-directory: ${{ matrix.package-group }}
run: |
npm install --ignore-scripts
npx lerna bootstrap --no-ci --ignore-scripts --hoist --nohoist='zone.js' -- --only=dev

- name: Lint
working-directory: ${{ matrix.package-group }}
run: |
npm run lint
npm run lint:examples
6 changes: 5 additions & 1 deletion .github/workflows/peer-api.yaml
Expand Up @@ -18,5 +18,9 @@ jobs:
- name: Install lerna
run: npm install -g lerna

- name: Check API dependency semantics
- name: Check API dependency semantics (stable)
run: lerna exec --ignore propagation-validation-server "node ../../scripts/peer-api-check.js"

- name: Check API dependency semantics (experimental)
working-directory: experimental
run: lerna exec --ignore propagation-validation-server "node ../../../scripts/peer-api-check.js"
14 changes: 0 additions & 14 deletions .github/workflows/release-please.yml

This file was deleted.

98 changes: 92 additions & 6 deletions .github/workflows/unit-test.yml
Expand Up @@ -6,7 +6,7 @@ on:
pull_request:

jobs:
unit-test:
node-tests-stable:
strategy:
fail-fast: false
matrix:
Expand All @@ -29,7 +29,7 @@ jobs:
path: |
node_modules
*/*/node_modules
key: unittest-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }}
key: node-tests-stable-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }}

- name: Bootstrap
if: steps.cache.outputs.cache-hit != 'true'
Expand All @@ -38,14 +38,15 @@ jobs:
npx lerna bootstrap --no-ci --hoist --nohoist='zone.js'

- name: Build 🔧
run: npm run compile
run: |
npm run compile

- name: Unit tests
run: npm run test
- name: Report Coverage
run: npm run codecov
if: ${{ matrix.node_version == '14' }}
browser-tests:
browser-tests-stable:
runs-on: ubuntu-latest
container:
image: circleci/node:14-browsers
Expand All @@ -64,17 +65,102 @@ jobs:
path: |
node_modules
*/*/node_modules
key: unittest-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }}
key: browser-tests-stable-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }}

- name: Bootstrap
if: steps.cache.outputs.cache-hit != 'true'
run: |
npm install --ignore-scripts
npx lerna bootstrap --no-ci --hoist --nohoist='zone.js'

- name: Build 🔧
run: |
npm run compile

- name: Unit tests
run: npm run test:browser
- name: Report Coverage
run: npm run codecov:browser
node-tests-experimental:
strategy:
fail-fast: false
matrix:
node_version: ["8", "10", "12", "14", "16"]
runs-on: ubuntu-latest
env:
NPM_CONFIG_UNSAFE_PERM: true
steps:
- name: Checkout
uses: actions/checkout@v1

- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node_version }}

- name: restore lerna
id: cache
uses: actions/cache@v2
with:
path: |
experimental/node_modules
experimental/packages/*/node_modules
key: node-tests-experimental-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('experimental/**/package.json') }}

- name: Bootstrap
if: steps.cache.outputs.cache-hit != 'true'
working-directory: experimental
run: |
npm install --ignore-scripts
npx lerna bootstrap --no-ci --hoist --nohoist='zone.js'

- name: Build 🔧
working-directory: experimental
run: |
npm run compile

- name: Unit tests
working-directory: experimental
run: npm run test
- name: Report Coverage
working-directory: experimental
run: npm run codecov
if: ${{ matrix.node_version == '14' }}
browser-tests-experimental:
runs-on: ubuntu-latest
container:
image: circleci/node:14-browsers
env:
NPM_CONFIG_UNSAFE_PERM: true
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Permission Setup
run: sudo chmod -R 777 /github /__w

- name: restore lerna
uses: actions/cache@v2
id: cache
with:
path: |
experimental/node_modules
experimental/packages/*/node_modules
key: browser-tests-experimental-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }}

- name: Bootstrap
if: steps.cache.outputs.cache-hit != 'true'
working-directory: experimental
run: |
npm install --ignore-scripts
npx lerna bootstrap --no-ci --hoist --nohoist='zone.js'

- name: Build 🔧
run: npm run compile
working-directory: experimental
run: |
npm run compile

- name: Unit tests
working-directory: experimental
run: npm run test:browser
- name: Report Coverage
working-directory: experimental
run: npm run codecov:browser
28 changes: 0 additions & 28 deletions .release-please-manifest.json

This file was deleted.