Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove usage of serviceName property in tests for otel collector #2491

Merged
merged 1 commit into from Sep 25, 2021
Merged

fix: remove usage of serviceName property in tests for otel collector #2491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/opentelemetry-exporter-otlp-http/test/node/CollectorMetricExporter.test.ts
View file
Open in desktop
Expand Up @@ -72,7 +72,6 @@ describe('OTLPMetricExporter - node with json over http', () => {
// Need to stub/spy on the underlying logger as the "diag" instance is global
const spyLoggerWarn = sinon.stub(diag, 'warn');
collectorExporter = new OTLPMetricExporter({
serviceName: 'basic-service',
url: address,
metadata,
} as any);
Expand Down
1 change: 0 additions & 1 deletion packages/opentelemetry-exporter-otlp-http/test/node/CollectorTraceExporter.test.ts
View file
Open in desktop
Expand Up @@ -58,7 +58,6 @@ describe('OTLPTraceExporter - node with json over http', () => {
// Need to stub/spy on the underlying logger as the "diag" instance is global
const spyLoggerWarn = sinon.stub(diag, 'warn');
collectorExporter = new OTLPTraceExporter({
serviceName: 'basic-service',
metadata,
url: address,
} as any);
Expand Down