chore: bump otlp trace exporters to v1

[rauno56]

Which problem is this PR solving?

The trace exporters are currently experimental even though we don't really consider them to be as such.

Short description of the changes

This moves the code from experimental folder to the main one changing as little on the way as possible.

• Since it already breaks all the links pointing to it - I'd love to remove the opentelemetry- prefix from the folder. Are we open to doing so?

[codecov]

Codecov Report

Merging #2626 (413567b) into main (8b9935b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2626   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files         144      144           
  Lines        5177     5177           
  Branches     1102     1102           
=======================================
  Hits         4790     4790           
  Misses        387      387           

Impacted Files	Coverage Δ
...s/exporter-trace-otlp-http/src/OTLPExporterBase.ts	92.15% <ø> (ø)
packages/exporter-trace-otlp-http/src/transform.ts	88.69% <ø> (ø)
packages/exporter-trace-otlp-http/src/types.ts	100.00% <ø> (ø)
packages/exporter-trace-otlp-http/src/util.ts	100.00% <ø> (ø)
...elemetry-exporter-trace-otlp-http/src/transform.ts
...opentelemetry-exporter-trace-otlp-http/src/util.ts
...pentelemetry-exporter-trace-otlp-http/src/types.ts
...y-exporter-trace-otlp-http/src/OTLPExporterBase.ts
... and 2 more

[dyladan]

Version must match the lerna.json version

[rauno56]

Thanks. Changed that. I did think that we version the packages independently though... 🤔

[dyladan]

No we only have 2 versions, the experimental and the stable versions are different. You may be thinking of contrib where the versions are completely independent.

[rauno56]

Tests pass with the package linked.
I don't see any significant unpublished changes - any ideas, @dyladan?

[vmarchaud]

lgtm, however i don't understand why experimentals are failling even after removing tsconfig refs

[dyladan]

Tests pass with the package linked. I don't see any significant unpublished changes - any ideas, @dyladan?

Sorry for such a late reply here. I found this reference https://github.com/Rauno56/opentelemetry-js/blob/chore/stable-otlp/experimental/packages/opentelemetry-exporter-metrics-otlp-http/tsconfig.esm.json#L13

[dyladan]

Tests are still failing but at least the build passes now. I haven't looked into the test failure yet but do you know what might be causing it?

[rauno56]

It might be because of some unpublished changes to the metrics exporter - it linked the packages before so that the tests could be in sync with the dev version of the implementation. Now when the packages are separated it relies on the published versions.

[vmarchaud]

It might be because of some unpublished changes to the metrics exporter - it linked the packages before so that the tests could be in sync with the dev version of the implementation. Now when the packages are separated it relies on the published versions.

I think we already dicussed skippign tests for metrics exporter while we are updating the SDK @dyladan ? i don't see a problem WDYT ?

[dyladan]

The published version should be the same as the last dev version. we published right before removing it. i'm not sure why that would cause the test to fail

[rauno56]

Redid the move to resolve conflicts...

[vmarchaud]

lgtm, just need to decide what to do with tests

[rauno56]

Yeah... I'm a bit lost here. After doing a clean install on just metrics grpc exporter, the tests pass locally.

Until I update to grpc.js@1.4.4 everywhere(to match the versions) I cannot even compile the packages locally:

Type 'import("/[..]/opentelemetry-js/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/node_modules/@grpc/grpc-js/build/src/metadata").Metadata'
     is not assignable to type 
     'import("/[..]/opentelemetry-js/experimental/node_modules/@grpc/grpc-js/build/src/metadata").Metadata'.

I'm following the CI process step-by-step. I'm afraid the issue is caused by some lerna-magic.

[rauno56]

Alright... as you can see... 🎉 ee61e1e

[dyladan]

LGTM

If you want to remove the opentelemetry- prefix i'm fine with it.

[rauno56]

If you want to remove the opentelemetry- prefix i'm fine with it.

👍 Will do.