Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retry link checks on code 429 with 'retry-after' header #2693

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Dec 29, 2021

Which problem is this PR solving?

There are chances that link checks get code 429 on github action. Allow the linkinator to retry with respecting the 'retry-after' header to suppress the "too many requests" code.

Links: https://github.com/open-telemetry/opentelemetry-js/runs/4653698160?check_suite_focus=true

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project

@legendecas legendecas requested a review from a team as a code owner December 29, 2021 16:03
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #2693 (a9907f6) into main (eba315b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2693   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files         151      151           
  Lines        5276     5276           
  Branches     1116     1116           
=======================================
  Hits         4884     4884           
  Misses        392      392           

@vmarchaud vmarchaud merged commit af377fa into open-telemetry:main Dec 30, 2021
@legendecas legendecas deleted the link-cheker branch December 30, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants