Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sdk-metrics): browser compatibility tests #2709

Merged
merged 3 commits into from
Jan 18, 2022
Merged

test(sdk-metrics): browser compatibility tests #2709

merged 3 commits into from
Jan 18, 2022

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Test sdk-metrics-base with karma on browsers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited

Codecov Report

Merging #2709 (f6ad924) into main (21fc8b5) will not change coverage.
The diff coverage is n/a.

❗ Current head f6ad924 differs from pull request most recent head 51e91c0. Consider uploading reports for the commit 51e91c0 to get more accurate results

@@           Coverage Diff           @@
##             main    #2709   +/-   ##
=======================================
  Coverage   93.04%   93.04%           
=======================================
  Files         155      155           
  Lines        5378     5378           
  Branches     1137     1137           
=======================================
  Hits         5004     5004           
  Misses        374      374

@legendecas

This comment has been minimized.

Sign in to view
@legendecas
Merge branch 'main' into metrics-ff/browser
453dd73 
# Conflicts:
#	experimental/packages/opentelemetry-sdk-metrics-base/test/export/PeriodicExportingMetricReader.test.ts
@legendecas legendecas marked this pull request as ready for review January 13, 2022 02:52
@legendecas legendecas requested a review from a team as a code owner January 13, 2022 02:52
@legendecas legendecas merged commit 206a1c3 into open-telemetry:main Jan 18, 2022
@legendecas legendecas deleted the metrics-ff/browser branch January 18, 2022 16:04
@legendecas legendecas added this to In progress in Metrics SDK via automation Feb 9, 2022
@legendecas legendecas moved this from In progress to Done in Metrics SDK Feb 9, 2022
@dyladan dyladan mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarchaud vmarchaud vmarchaud approved these changes

@johnbley johnbley johnbley approved these changes

Assignees
No one assigned
Labels
internal
Projects
Metrics SDK
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@legendecas @vmarchaud @johnbley