Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: indent the code with eslint #2923

Merged
merged 6 commits into from
Apr 26, 2022
Merged

chore: indent the code with eslint #2923

merged 6 commits into from
Apr 26, 2022

Conversation

blumamir
Copy link
Member

Which problem is this PR solving?

The linting did not inforced any indentation on the code.

Short description of the changes

Added the following rule to eslint.config.js:

  rules: {
    "indent": ["error", 2],

All other changes are indentation fixes auto generated by eslint when invoking yarn lint:fix on root.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Only style changes, no functional change in code.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@blumamir blumamir requested a review from a team as a code owner April 24, 2022 10:42
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2923 (fba60d2) into main (6710cdd) will not change coverage.
The diff coverage is 100.00%.

❗ Current head fba60d2 differs from pull request most recent head 2c6d78f. Consider uploading reports for the commit 2c6d78f to get more accurate results

@@           Coverage Diff           @@
##             main    #2923   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         171      171           
  Lines        5346     5346           
  Branches     1155     1155           
=======================================
  Hits         4935     4935           
  Misses        411      411           
Impacted Files Coverage Δ
...ges/opentelemetry-instrumentation-http/src/http.ts 94.46% <ø> (ø)
...entelemetry-instrumentation/src/instrumentation.ts 77.77% <ø> (ø)
...atform/node/instrumentationNodeModuleDefinition.ts 14.28% <ø> (ø)
...src/platform/node/instrumentationNodeModuleFile.ts 100.00% <ø> (ø)
...sdk-metrics-base/src/exemplar/ExemplarReservoir.ts 95.65% <ø> (ø)
...etry-sdk-metrics-base/src/export/MetricExporter.ts 27.27% <ø> (ø)
...sync-hooks/src/AbstractAsyncHooksContextManager.ts 97.01% <ø> (ø)
packages/opentelemetry-core/src/baggage/utils.ts 75.75% <ø> (ø)
...exporter-trace-otlp-proto/src/OTLPTraceExporter.ts 100.00% <100.00%> (ø)
...er-metrics-otlp-http/src/OTLPMetricExporterBase.ts 57.14% <100.00%> (ø)
... and 5 more

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just left a few questions.

@legendecas legendecas merged commit ce7e98f into open-telemetry:main Apr 26, 2022
aabmass pushed a commit to aabmass/opentelemetry-js that referenced this pull request Apr 28, 2022
* chore: indent the code with eslint

* chore: update changelog

* chore: add lint switch case indent

Co-authored-by: legendecas <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants