Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-trace-base): fix crash on environments without global document #3000

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Fixes crash on sdk-trace-base BatchSpanProcess in environments like webworker and deno.

Short description of the changes

  • Fix checks on presence of document.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • WebWorker test enabled for sdk-trace-base
  • Add new simple case for BatchSpanProcessor

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #3000 (56d8c85) into main (0ed21bc) will decrease coverage by 0.15%.
The diff coverage is 60.00%.

❗ Current head 56d8c85 differs from pull request most recent head c140e8e. Consider uploading reports for the commit c140e8e to get more accurate results

@@            Coverage Diff             @@
##             main    #3000      +/-   ##
==========================================
- Coverage   92.78%   92.63%   -0.16%     
==========================================
  Files         185      187       +2     
  Lines        6142     6166      +24     
  Branches     1296     1301       +5     
==========================================
+ Hits         5699     5712      +13     
- Misses        443      454      +11     
Impacted Files Coverage Δ
.../src/platform/browser/export/BatchSpanProcessor.ts 45.00% <33.33%> (ø)
...kages/opentelemetry-sdk-trace-base/karma.worker.js 100.00% <100.00%> (ø)

@legendecas legendecas marked this pull request as ready for review May 30, 2022 16:15
@legendecas legendecas requested a review from a team as a code owner May 30, 2022 16:15
@legendecas legendecas requested a review from a team June 8, 2022 14:58
@vmarchaud vmarchaud merged commit 922e963 into open-telemetry:main Jun 8, 2022
@legendecas legendecas deleted the sdk-trace-base-worker branch June 9, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants