Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resources): fix when attribute values contain spaces #3302

Merged
merged 12 commits into from
Oct 14, 2022

Conversation

anthony-telljohann
Copy link
Contributor

Which problem is this PR solving?

EnvDetector throwing errors when attribute values contain spaces.

Fixes #3295

Short description of the changes

EnvDetector no longer throws errors when an attribute value contains a space.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Existing unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@anthony-telljohann anthony-telljohann requested a review from a team as a code owner October 8, 2022 13:41
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@vmarchaud vmarchaud requested a review from a team October 8, 2022 14:42
@vmarchaud
Copy link
Member

@anthony-telljohann You'll need to sign the CLA with above comment so we can accept the contribution

@anthony-telljohann
Copy link
Contributor Author

I'll work with my company on getting the CLA signed first thing Monday morning.

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #3302 (fad904a) into main (07a16b7) will increase coverage by 0.84%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3302      +/-   ##
==========================================
+ Coverage   92.61%   93.45%   +0.84%     
==========================================
  Files         130       91      -39     
  Lines        3128     2201     -927     
  Branches      656      441     -215     
==========================================
- Hits         2897     2057     -840     
+ Misses        231      144      -87     
Impacted Files Coverage Δ
...entelemetry-resources/src/detectors/EnvDetector.ts 88.23% <100.00%> (ø)
...ckages/opentelemetry-core/src/baggage/constants.ts
packages/opentelemetry-core/src/utils/promise.ts
packages/opentelemetry-core/src/common/time.ts
...perimental/packages/otlp-exporter-base/src/util.ts
packages/opentelemetry-core/src/utils/wrap.ts
...s/opentelemetry-core/src/trace/suppress-tracing.ts
...es/opentelemetry-instrumentation/src/autoLoader.ts
...lemetry-core/src/trace/sampler/AlwaysOffSampler.ts
packages/opentelemetry-core/src/baggage/utils.ts
... and 30 more

@dyladan
Copy link
Member

dyladan commented Oct 11, 2022

Any update on the CLA?

@anthony-telljohann
Copy link
Contributor Author

Any update on the CLA?

Still working on it. We have a list of people that meet the requirements to be CLA Managers. Still need to find one that is able and willing to create the CLA Manager account to authorize the contribution.

@anthony-telljohann
Copy link
Contributor Author

Just noticed some of the eslint errors. I'll patch this up asap.

@anthony-telljohann
Copy link
Contributor Author

Still working on getting the CLA signed.

@dyladan
Copy link
Member

dyladan commented Oct 13, 2022

Browser and webworker failures are unrelated. See #3328

@anthony-telljohann
Copy link
Contributor Author

So close to getting the CLA signed. I've got the correct person to make the EasyCLA account.

@anthony-telljohann
Copy link
Contributor Author

CLA signed.

@anthony-telljohann
Copy link
Contributor Author

@dyladan would love to merge this in as soon as possible. Anything I can do to help expedite?

@dyladan
Copy link
Member

dyladan commented Oct 14, 2022

Nope. I merged main into this earlier and was just waiting for tests to pass.

@dyladan dyladan merged commit a7d053a into open-telemetry:main Oct 14, 2022
@anthony-telljohann anthony-telljohann deleted the fix-env-detector branch October 14, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(EnvDetector): does not support otel resource attribute values containing spaces
4 participants